components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc - Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc

Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*) (Closed)

Patch Set: Fix Compilation Error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/bookmarks/browser/bookmark_expanded_state_tracker.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc

index 04280b08bc719bd4a41a9f8480761e859d8ead81..5545638f44db364ccc55eb5c4df90a720657ea33 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc

@@ -78,7 +78,8 @@ void AddInt64ToListPref(size_t index,

int64_t length,

base::ListValue* list_update) {

int64_t value = GetInt64PrefValue(*list_update, index) + length;

- list_update->Set(index, new base::Value(base::Int64ToString(value)));

+ list_update->Set(index,

+ base::MakeUnique<base::Value>(base::Int64ToString(value)));

}

// DailyContentLengthUpdate maintains a data saving pref. The pref is a list