Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2838853002: Reland of: chromeos: Add CPU temperature reader (Closed)

Created:
3 years, 8 months ago by Simon Que
Modified:
3 years, 8 months ago
Reviewers:
stevenjb, Daniel Erat
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of: chromeos: Add CPU temperature reader Original issue: https://codereview.chromium.org/2823583002/ Reason for revert: Build errors due to non-exported symbols ===================================== Reads from hwmon in sysfs. This does the same thing as ReadCPUTempInfo() in chrome/browser/chromeos/policy/device_status_collector.cc, but it is available to the rest of Chrome. BUG=chromium:709102 Review-Url: https://codereview.chromium.org/2838853002 Cr-Commit-Position: refs/heads/master@{#466999} Committed: https://chromium.googlesource.com/chromium/src/+/a15eba14554af2a846bf977301dee043a0aa54a1

Patch Set 1 #

Patch Set 2 : Add CHROMEOS_EXPORT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -0 lines) Patch
M chromeos/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A chromeos/system/cpu_temperature_reader.h View 1 1 chunk +61 lines, -0 lines 0 comments Download
A chromeos/system/cpu_temperature_reader.cc View 1 chunk +117 lines, -0 lines 0 comments Download
A chromeos/system/cpu_temperature_reader_unittest.cc View 1 chunk +136 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Simon Que
3 years, 8 months ago (2017-04-25 11:56:48 UTC) #2
Daniel Erat
lgtm
3 years, 8 months ago (2017-04-25 13:38:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838853002/20001
3 years, 8 months ago (2017-04-25 13:50:59 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 15:42:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a15eba14554af2a846bf977301de...

Powered by Google App Engine
This is Rietveld 408576698