[tools] add script to simplify backporting patch to Node.js

[tools] add script to simplify backporting patch to Node.js

usage: backport_node.py <v8 dir> <node dir> <commit hash> [--no-review]

R=franzih@chromium.org, machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2838843002
Cr-Commit-Position: refs/heads/master@{#44853}
Committed: https://chromium.googlesource.com/v8/v8/+/fed3e09356004521023253cfea903e72c42c2e82

[Michael Achenbach, 2017-04-25 12:33:45]

lgtm

https://codereview.chromium.org/2838843002/diff/1/tools/release/backport_node.py
File tools/release/backport_node.py (right):

https://codereview.chromium.org/2838843002/diff/1/tools/release/backport_node...
tools/release/backport_node.py:15: print subprocess.check_call(["git",
"diff-tree", "-p", options.commit], cwd=options.v8_path)
Why do we output the whole patch? Isn't this sometimes very large?

https://codereview.chromium.org/2838843002/diff/1/tools/release/backport_node...
tools/release/backport_node.py:18: patch.wait()
Probably many roads to Rome. I used to use a different approach for piping
between processes:
https://chromium.googlesource.com/v8/v8/+/2ac17e34cd9847bac75fdd03a8d65cb4e8b...

but that's just stackoverflow wisdom.

https://codereview.chromium.org/2838843002/diff/1/tools/release/test_backport...
File tools/release/test_backport_node.py (right):

https://codereview.chromium.org/2838843002/diff/1/tools/release/test_backport...
tools/release/test_backport_node.py:51: # Run update script.
nit: Run backport script.

[Franzi, 2017-04-25 12:39:50]

https://codereview.chromium.org/2838843002/diff/1/tools/release/backport_node.py
File tools/release/backport_node.py (right):

https://codereview.chromium.org/2838843002/diff/1/tools/release/backport_node...
tools/release/backport_node.py:56: parser =
argparse.ArgumentParser(description="Backport V8 commit to Node.js")
Can you add some docu? I.e., what is this for, how to use it? Do you need a node
checkout? From which folder do you run it?

[Yang, 2017-04-25 13:15:41]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-04-25 13:15:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2838843002/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2017-04-25 13:15:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 13:39:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493126141425040,
"parent_rev": "e671ed361026d01342d6032c3dab84abe48d19a6", "commit_rev":
"fed3e09356004521023253cfea903e72c42c2e82"}

[commit-bot: I haz the power, 2017-04-25 13:39:10]

Description was changed from

==========
[tools] add script to simplify backporting patch to Node.js

usage: backport_node.py <v8 dir> <node dir> <commit hash> [--no-review]

R=franzih@chromium.org, machenbach@chromium.org
==========

to

==========
[tools] add script to simplify backporting patch to Node.js

usage: backport_node.py <v8 dir> <node dir> <commit hash> [--no-review]

R=franzih@chromium.org, machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2838843002
Cr-Commit-Position: refs/heads/master@{#44853}
Committed:
https://chromium.googlesource.com/v8/v8/+/fed3e09356004521023253cfea903e72c42...
==========

[commit-bot: I haz the power, 2017-04-25 13:39:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/fed3e09356004521023253cfea903e72c42...

[Yang, 2017-04-25 18:22:05]

https://codereview.chromium.org/2838843002/diff/1/tools/release/backport_node.py
File tools/release/backport_node.py (right):

https://codereview.chromium.org/2838843002/diff/1/tools/release/backport_node...
tools/release/backport_node.py:15: print subprocess.check_call(["git",
"diff-tree", "-p", options.commit], cwd=options.v8_path)
On 2017/04/25 12:33:45, Michael Achenbach wrote:
> Why do we output the whole patch? Isn't this sometimes very large?

Debugging remnant. Removing.

https://codereview.chromium.org/2838843002/diff/1/tools/release/backport_node...
tools/release/backport_node.py:18: patch.wait()
On 2017/04/25 12:33:45, Michael Achenbach wrote:
> Probably many roads to Rome. I used to use a different approach for piping
> between processes:
>
https://chromium.googlesource.com/v8/v8/+/2ac17e34cd9847bac75fdd03a8d65cb4e8b...
> 
> but that's just stackoverflow wisdom.

Mine was a piece of stackoverflow wisdom as well :)

https://codereview.chromium.org/2838843002/diff/1/tools/release/backport_node...
tools/release/backport_node.py:56: parser =
argparse.ArgumentParser(description="Backport V8 commit to Node.js")
On 2017/04/25 12:39:50, Franzi wrote:
> Can you add some docu? I.e., what is this for, how to use it? Do you need a
node
> checkout? From which folder do you run it?

Done. Also added documentation for update_node.py