Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 2838823002: [LayoutNG] Add shape options to NGInlineNode (Closed)

Created:
3 years, 8 months ago by eae
Modified:
3 years, 8 months ago
Reviewers:
kojii
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Add shape options to NGInlineNode Add options for controlling whether pre- and post-context should be used and pack it together with the other bool/enum options to preserve space. BUG=636993 R=kojii@chromium.org Review-Url: https://codereview.chromium.org/2838823002 Cr-Commit-Position: refs/heads/master@{#466917} Committed: https://chromium.googlesource.com/chromium/src/+/f420968746fa2ec23675dc7d1116de9548e43617

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -10 lines) Patch
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.h View 4 chunks +26 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
eae
As discussed in the meeting earlier today.
3 years, 8 months ago (2017-04-25 06:15:32 UTC) #5
kojii
lgtm
3 years, 8 months ago (2017-04-25 06:18:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838823002/1
3 years, 8 months ago (2017-04-25 06:19:09 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 07:28:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f420968746fa2ec23675dc7d1116...

Powered by Google App Engine
This is Rietveld 408576698