Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1166)

Issue 2838813005: Add some .h files under chrome/browser to .gn files. (Closed)

Created:
3 years, 8 months ago by Nico
Modified:
3 years, 8 months ago
Reviewers:
jdufault
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org, Alexander Alekseev
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some .h files under chrome/browser to .gn files. BUG=661774 Review-Url: https://codereview.chromium.org/2838813005 Cr-Commit-Position: refs/heads/master@{#467405} Committed: https://chromium.googlesource.com/chromium/src/+/40b32c7bef5d14f90e02b8c20630f98884316a67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 4 chunks +5 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Nico
3 years, 8 months ago (2017-04-26 17:40:13 UTC) #4
jdufault
lgtm, thanks
3 years, 8 months ago (2017-04-26 18:29:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838813005/1
3 years, 8 months ago (2017-04-26 19:07:13 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 19:12:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/40b32c7bef5d14f90e02b8c20630...

Powered by Google App Engine
This is Rietveld 408576698