Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2838813003: Revert of [Chromecast] Use base::FeatureList to control features. (Closed)

Created:
3 years, 8 months ago by slan
Modified:
3 years, 8 months ago
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chromecast] Use base::FeatureList to control features. (patchset #7 id:120001 of https://codereview.chromium.org/2825873002/ ) Reason for revert: cast_features_browsertest.cc is flaky on our internal CQ bot - it's unclear why this did not manifest on the Chromium trybots. I assume that state persisting in the PrefService between tests is causing the flakiness. Reverting this patch until I understand the root cause. Original issue's description: > [Chromecast] Use base::FeatureList to control features. > > In Chromium, Finch-enabled features are controlled through base::FeatureList, > a class which abstracts the experiment framework and developer overrides > from client code. Though Chromecast's experiment framework is fundamentally > different (in that it is server-driven) Cast builds can still make use of > this class. Introduce some utilities to help. > > At boot-up, the pref store will be queried for experiment configs, which > were cached to disk on the most recent config fetch from the last boot > cycle. If a developer overrides these features from the command line, > that value takes precedence. These features will be used to initialize > base::FeatureList, which can then be statically queried from any client > code that depends on //base. > > This patch does not actually introduce or convert any existing features > to use this framework. > > BUG=714291 > BUG= internal b/35424335 > > Review-Url: https://codereview.chromium.org/2825873002 > Cr-Commit-Position: refs/heads/master@{#466507} > Committed: https://chromium.googlesource.com/chromium/src/+/ef03d2b9a67352094516f4e866373378fb961ee8 TBR=halliwell@chromium.org,maclellant@chromium.org,asvitkine@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=714291 Review-Url: https://codereview.chromium.org/2838813003 Cr-Commit-Position: refs/heads/master@{#467041} Committed: https://chromium.googlesource.com/chromium/src/+/46cfdeaf9d8e4c78dee471195ad0c1b3a6dcf9e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -749 lines) Patch
M chromecast/base/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D chromecast/base/cast_features.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chromecast/base/cast_features.cc View 1 chunk +0 lines, -197 lines 0 comments Download
D chromecast/base/cast_features_unittest.cc View 1 chunk +0 lines, -285 lines 0 comments Download
M chromecast/base/pref_names.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chromecast/base/pref_names.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chromecast/browser/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M chromecast/browser/cast_browser_main_parts.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chromecast/browser/cast_browser_main_parts.cc View 4 chunks +5 lines, -23 lines 0 comments Download
M chromecast/browser/pref_service_helper.cc View 1 chunk +0 lines, -2 lines 0 comments Download
D chromecast/browser/test/cast_features_browsertest.cc View 1 chunk +0 lines, -174 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
slan
Created Revert of [Chromecast] Use base::FeatureList to control features.
3 years, 8 months ago (2017-04-25 16:06:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838813003/1
3 years, 8 months ago (2017-04-25 16:06:59 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 17:55:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/46cfdeaf9d8e4c78dee471195ad0...

Powered by Google App Engine
This is Rietveld 408576698