Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2838793002: auth: Split UI pages into admin and non-admin ones. (Closed)

Created:
3 years, 8 months ago by Vadim Sh.
Modified:
3 years, 8 months ago
Reviewers:
nodir
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

auth: Split UI pages into admin and non-admin ones. Admin pages (involved in initial bootstrap) will stay as they are. Non-admin pages will be converted to use client-side Google Sign-In flow. R=nodir@chromium.org BUG=714821 Review-Url: https://codereview.chromium.org/2838793002 Committed: https://github.com/luci/luci-py/commit/a51c5be37a4090e71e8eb7e31a2c51da37c0f96a

Patch Set 1 #

Patch Set 2 : don't use google-signin-client_id yet #

Total comments: 4

Patch Set 3 : simplify admin pages a bit more #

Patch Set 4 : nit #

Total comments: 6

Patch Set 5 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -281 lines) Patch
M appengine/components/components/auth/ui/templates/access_denied.html View 1 chunk +37 lines, -20 lines 0 comments Download
A + appengine/components/components/auth/ui/templates/admin/access_denied.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + appengine/components/components/auth/ui/templates/admin/base.html View 1 2 3 4 2 chunks +5 lines, -3 lines 0 comments Download
A + appengine/components/components/auth/ui/templates/admin/bootstrap.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + appengine/components/components/auth/ui/templates/admin/bootstrap_done.html View 1 chunk +1 line, -1 line 0 comments Download
A + appengine/components/components/auth/ui/templates/admin/bootstrap_oauth.html View 1 chunk +1 line, -1 line 0 comments Download
A + appengine/components/components/auth/ui/templates/admin/linking.html View 1 chunk +1 line, -1 line 0 comments Download
A + appengine/components/components/auth/ui/templates/admin/linking_done.html View 1 chunk +1 line, -1 line 0 comments Download
D appengine/components/components/auth/ui/templates/base_minimal.html View 1 chunk +0 lines, -26 lines 0 comments Download
D appengine/components/components/auth/ui/templates/bootstrap.html View 1 chunk +0 lines, -31 lines 0 comments Download
D appengine/components/components/auth/ui/templates/bootstrap_done.html View 1 chunk +0 lines, -24 lines 0 comments Download
D appengine/components/components/auth/ui/templates/bootstrap_oauth.html View 1 chunk +0 lines, -29 lines 0 comments Download
D appengine/components/components/auth/ui/templates/linking.html View 1 chunk +0 lines, -30 lines 0 comments Download
D appengine/components/components/auth/ui/templates/linking_done.html View 1 chunk +0 lines, -19 lines 0 comments Download
M appengine/components/components/auth/ui/ui.py View 1 2 3 4 11 chunks +150 lines, -91 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Vadim Sh.
PTAL Mostly code moves. https://codereview.chromium.org/2838793002/diff/20001/appengine/components/components/auth/ui/templates/access_denied.html File appengine/components/components/auth/ui/templates/access_denied.html (right): https://codereview.chromium.org/2838793002/diff/20001/appengine/components/components/auth/ui/templates/access_denied.html#newcode1 appengine/components/components/auth/ui/templates/access_denied.html:1: <!DOCTYPE html> This template will ...
3 years, 8 months ago (2017-04-25 00:03:18 UTC) #1
nodir
lgtm https://codereview.chromium.org/2838793002/diff/60001/appengine/components/components/auth/ui/templates/admin/base.html File appengine/components/components/auth/ui/templates/admin/base.html (right): https://codereview.chromium.org/2838793002/diff/60001/appengine/components/components/auth/ui/templates/admin/base.html#newcode21 appengine/components/components/auth/ui/templates/admin/base.html:21: if (confirm('You\'ll be signed out from ALL your ...
3 years, 8 months ago (2017-04-25 20:26:50 UTC) #2
Vadim Sh.
https://codereview.chromium.org/2838793002/diff/60001/appengine/components/components/auth/ui/templates/admin/base.html File appengine/components/components/auth/ui/templates/admin/base.html (right): https://codereview.chromium.org/2838793002/diff/60001/appengine/components/components/auth/ui/templates/admin/base.html#newcode21 appengine/components/components/auth/ui/templates/admin/base.html:21: if (confirm('You\'ll be signed out from ALL your google ...
3 years, 8 months ago (2017-04-25 20:45:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838793002/80001
3 years, 8 months ago (2017-04-25 20:45:54 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 20:48:12 UTC) #9
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://github.com/luci/luci-py/commit/a51c5be37a4090e71e8eb7e31a2c51da37c0f96a

Powered by Google App Engine
This is Rietveld 408576698