Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2838753002: x11: Use opaque window for dnd without composite. (Closed)

Created:
3 years, 8 months ago by sunnyps
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

x11: Use opaque window for dnd without composite. Use an opaque window for drag and drop when a compositing manager is absent. Otherwise, the drag and drop window is displayed black. BUG=712896 Change-Id: I753cc26f5713579e3fc6ffbd952c62ee44d9ae44 Reviewed-on: https://chromium-review.googlesource.com/481103 Reviewed-by: Kenneth Russell <kbr@chromium.org>; Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>; Reviewed-by: Elliot Glaysher <erg@chromium.org>; Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>; Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#466468}(cherry picked from commit 4dc0ad690ed3a08c56b78b0f679580f74d3acf73) Review-Url: https://codereview.chromium.org/2838753002 . Cr-Commit-Position: refs/branch-heads/3071@{#179} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/c3cfef7a2bafdb9753d97e01f544f9ab2083bc3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M content/browser/gpu/gpu_internals_ui.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M ui/base/x/x11_util.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/x/x11_util.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
sunnyps
3 years, 8 months ago (2017-04-24 21:13:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c3cfef7a2bafdb9753d97e01f544f9ab2083bc3c.

Powered by Google App Engine
This is Rietveld 408576698