Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2838713004: Replace SupportsWeakPtr with WeakPtrFactory in VideoResourceUpdater (Closed)

Created:
3 years, 8 months ago by Chandan
Modified:
3 years, 7 months ago
Reviewers:
danakj
CC:
chromium-reviews, posciak+watch_chromium.org, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace SupportsWeakPtr with WeakPtrFactory in VideoResourceUpdater VideoResourceUpdater uses weak pointers within the class only. Hence, it does not have to inherit SupportsWeakPtr. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2838713004 Cr-Commit-Position: refs/heads/master@{#467883} Committed: https://chromium.googlesource.com/chromium/src/+/c454c56eb566695c4f56909366f603bcc1c031ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M cc/resources/video_resource_updater.h View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 6 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Chandan
PTAL. Thank you.
3 years, 8 months ago (2017-04-26 13:51:18 UTC) #3
danakj
Thanks, LGTM
3 years, 7 months ago (2017-04-27 20:03:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838713004/1
3 years, 7 months ago (2017-04-27 20:11:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/builds/8629)
3 years, 7 months ago (2017-04-27 20:42:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838713004/1
3 years, 7 months ago (2017-04-28 02:54:57 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 04:04:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c454c56eb566695c4f56909366f6...

Powered by Google App Engine
This is Rietveld 408576698