Chromium Code Reviews Chromium Code Reviews
Issue 2838673003:
[Devtools][Regression] Fixed websocket frame selection loss on frame received (Closed)
| Index: third_party/WebKit/LayoutTests/http/tests/inspector/websocket/network-preserve-selection-on-frame-receive.html |
| diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/websocket/network-preserve-selection-on-frame-receive.html b/third_party/WebKit/LayoutTests/http/tests/inspector/websocket/network-preserve-selection-on-frame-receive.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..c10b219850d66a0190cf7c81c711c576f3739bd5 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/http/tests/inspector/websocket/network-preserve-selection-on-frame-receive.html |
| @@ -0,0 +1,37 @@ |
| +<html> |
| +<head> |
| +<script src="/inspector/inspector-test.js"></script> |
| +<script src="/inspector/network-test.js"></script> |
| +<script> |
| +async function test() { |
| + InspectorTest.recordNetwork(); |
| + |
| + const wsUrl = "ws://localhost:8880/echo"; |
| + const networkLogView = UI.panels.network._networkLogView; |
| + const dataGrid = networkLogView._dataGrid; |
| + var sdkWebsocketPromise = InspectorTest.sdkRequestStartedFromUrlPromise(wsUrl); |
| + |
| + var wsRemoteObject = await InspectorTest.makeWebsocketPromise(wsUrl); |
| + var sdkWebsocketRequest = await sdkWebsocketPromise; |
| + await InspectorTest.waitForRequestResponse(sdkWebsocketRequest); |
| + |
| + var node = InspectorTest.networkLogViewNodeForRequestId(sdkWebsocketRequest.requestId()); |
| + networkLogView._refresh(); |
| + node.select(); |
| + InspectorTest.addResult("Selected Request: " + (dataGrid.selectedNode && dataGrid.selectedNode.request().url()) || ''); |
|
dgozman
2017/04/25 21:20:46
Extract dumpSelectedRequest function.
allada
2017/04/27 17:03:19
Done.
|
| + |
| + InspectorTest.addResult("Sending Websocket frame"); |
| + await InspectorTest.callFunctionInPageOnRemoteObjectAsync(wsRemoteObject, "this.send('test')"); |
|
dgozman
2017/04/25 21:20:46
Why do we need remote object? Just store it on win
allada
2017/04/27 17:03:19
I was trying to make the code verbose in what it i
|
| + await InspectorTest.waitForWebsocketFrameReceived(sdkWebsocketRequest, "test"); |
| + networkLogView._refresh(); |
| + InspectorTest.addResult("Websocket Frame Received"); |
| + |
| + InspectorTest.addResult("Selected Request: " + (dataGrid.selectedNode && dataGrid.selectedNode.request().url()) || ''); |
| + InspectorTest.completeTest(); |
| +} |
| +</script> |
| +</head> |
| +<body onload="runTest()"> |
| +<p>Tests that WebSocket network requests do not loose focus on frame being received.</p> |
| +</body> |
| +</html> |
