third_party/WebKit/LayoutTests/http/tests/inspector/websocket/network-preserve-selection-on-frame-receive.html - Issue 2838673003: [Devtools][Regression] Fixed websocket frame selection loss on frame received

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/inspector/websocket/network-preserve-selection-on-frame-receive.html

Issue 2838673003: [Devtools][Regression] Fixed websocket frame selection loss on frame received (Closed)

Patch Set: [Devtools] Fixed websocket frame selection loss on frame received Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js ('K') | « third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/websocket/network-preserve-selection-on-frame-receive-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="/inspector/inspector-test.js"></script>

	4 <script src="/inspector/network-test.js"></script>

	5 <script>

	6 async function test() {

	7 InspectorTest.recordNetwork();

	8

	9 const wsUrl = "ws://localhost:8880/echo";

	10 const networkLogView = UI.panels.network._networkLogView;

	11 const dataGrid = networkLogView._dataGrid;

	12 var sdkWebsocketPromise = InspectorTest.sdkRequestStartedFromUrlPromise(wsUr l);

	13

	14 var wsRemoteObject = await InspectorTest.makeWebsocketPromise(wsUrl);

	15 var sdkWebsocketRequest = await sdkWebsocketPromise;

	16 await InspectorTest.waitForRequestResponse(sdkWebsocketRequest);

	17

	18 var node = InspectorTest.networkLogViewNodeForRequestId(sdkWebsocketRequest. requestId());

	19 networkLogView._refresh();

	20 node.select();

	21 InspectorTest.addResult("Selected Request: " + (dataGrid.selectedNode && dat aGrid.selectedNode.request().url()) \|\| '');
	dgozman 2017/04/25 21:20:46 Extract dumpSelectedRequest function. Extract dumpSelectedRequest function. allada 2017/04/27 17:03:19 Done. Show quoted text On 2017/04/25 21:20:46, dgozman wrote: > Extract dumpSelectedRequest function. Done.
	22

	23 InspectorTest.addResult("Sending Websocket frame");

	24 await InspectorTest.callFunctionInPageOnRemoteObjectAsync(wsRemoteObject, "t his.send('test')");
	dgozman 2017/04/25 21:20:46 Why do we need remote object? Just store it on win Why do we need remote object? Just store it on window in the page. allada 2017/04/27 17:03:19 I was trying to make the code verbose in what it i Show quoted text On 2017/04/25 21:20:46, dgozman wrote: > Why do we need remote object? Just store it on window in the page. I was trying to make the code verbose in what it is doing. If I store it on the main page and work directly with it, than we end up with black magic and concurrency hell. I feel it is more natural to say, "create this object in page" ... "run this code on this object that should exist in page", rather than calling methods in the page and forcing global state. (keep in mind there are few cases where RemoteObjects make sense for this, but I believe this is one of them.
	25 await InspectorTest.waitForWebsocketFrameReceived(sdkWebsocketRequest, "test ");

	26 networkLogView._refresh();

	27 InspectorTest.addResult("Websocket Frame Received");

	28

	29 InspectorTest.addResult("Selected Request: " + (dataGrid.selectedNode && dat aGrid.selectedNode.request().url()) \|\| '');

	30 InspectorTest.completeTest();

	31 }

	32 </script>

	33 </head>

	34 <body onload="runTest()">

	35 <p>Tests that WebSocket network requests do not loose focus on frame being recei ved.</p>

	36 </body>

	37 </html>

OLD	NEW