Allow storing null navigations in CRWWKNavigationStates.

Allow storing null navigations in CRWWKNavigationStates.

This CL (6 of 7) is a part of large refactoring to create
NavigationContext when navigation was started, not when it is finished.
This refactoring will allow to pass the same instance of
NavigationContext to DidStartNavigation and DidFinishNavigation
(crbug.com/713836). Also this will allow to associate NavigationItem
with NavigationContext object to commit non-latest navigation
(crbug.com/712269).

WKWebView passes null WKNavigation to WKNavigationDelegate callbacks for
window opening navigation actions. This is a normal flow so
CRWWKNavigationStates should be able to store null navigations. Because
there can be at most one window opening navigation it is safe to use
unique key for storing null navigation.

BUG=713836, 712269
Review-Url: https://codereview.chromium.org/2838593002
Cr-Commit-Position: refs/heads/master@{#470439}
Committed: https://chromium.googlesource.com/chromium/src/+/2c79b906de7b97f04ea867398b884ec9c0341839

[Eugene But (OOO till 7-30), 2017-04-24 14:04:50]

eugenebut@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[kkhorimoto, 2017-04-25 14:00:11]

lgtm

https://codereview.chromium.org/2838593002/diff/1/ios/web/web_state/ui/crw_wk...
File ios/web/web_state/ui/crw_wk_navigation_states.mm (right):

https://codereview.chromium.org/2838593002/diff/1/ios/web/web_state/ui/crw_wk...
ios/web/web_state/ui/crw_wk_navigation_states.mm:103: _nullNavigation =
static_cast<WKNavigation*>([NSNull null]);
Is reinterpret_cast more appropriate here?

[Eugene But (OOO till 7-30), 2017-04-26 05:51:33]

Thanks!

https://codereview.chromium.org/2838593002/diff/1/ios/web/web_state/ui/crw_wk...
File ios/web/web_state/ui/crw_wk_navigation_states.mm (right):

https://codereview.chromium.org/2838593002/diff/1/ios/web/web_state/ui/crw_wk...
ios/web/web_state/ui/crw_wk_navigation_states.mm:103: _nullNavigation =
static_cast<WKNavigation*>([NSNull null]);
On 2017/04/25 14:00:11, kkhorimoto_ wrote:
> Is reinterpret_cast more appropriate here? 
This translates one Obc-C pointer type to another, so static_cast should be
fine.

[Eugene But (OOO till 7-30), 2017-05-09 21:24:48]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-05-09 21:24:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
kkhorimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/2838593002/#ps20001
(title: "Rebased")

[commit-bot: I haz the power, 2017-05-09 21:25:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 23:49:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494365088189350,
"parent_rev": "aabbebd7db9e03fc5efdec66c427216cb754db6a", "commit_rev":
"2c79b906de7b97f04ea867398b884ec9c0341839"}

[commit-bot: I haz the power, 2017-05-09 23:50:08]

Description was changed from

==========
Allow storing null navigations in CRWWKNavigationStates.

This CL (6 of 7) is a part of large refactoring to create
NavigationContext when navigation was started, not when it is finished.
This refactoring will allow to pass the same instance of
NavigationContext to DidStartNavigation and DidFinishNavigation
(crbug.com/713836). Also this will allow to associate NavigationItem
with NavigationContext object to commit non-latest navigation
(crbug.com/712269).

WKWebView passes null WKNavigation to WKNavigationDelegate callbacks for
window opening navigation actions. This is a normal flow so
CRWWKNavigationStates should be able to store null navigations. Because
there can be at most one window opening navigation it is safe to use
unique key for storing null navigation.

BUG=713836,712269
==========

to

==========
Allow storing null navigations in CRWWKNavigationStates.

This CL (6 of 7) is a part of large refactoring to create
NavigationContext when navigation was started, not when it is finished.
This refactoring will allow to pass the same instance of
NavigationContext to DidStartNavigation and DidFinishNavigation
(crbug.com/713836). Also this will allow to associate NavigationItem
with NavigationContext object to commit non-latest navigation
(crbug.com/712269).

WKWebView passes null WKNavigation to WKNavigationDelegate callbacks for
window opening navigation actions. This is a normal flow so
CRWWKNavigationStates should be able to store null navigations. Because
there can be at most one window opening navigation it is safe to use
unique key for storing null navigation.

BUG=713836,712269

Review-Url: https://codereview.chromium.org/2838593002
Cr-Commit-Position: refs/heads/master@{#470439}
Committed:
https://chromium.googlesource.com/chromium/src/+/2c79b906de7b97f04ea867398b88...
==========

[commit-bot: I haz the power, 2017-05-09 23:50:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2c79b906de7b97f04ea867398b88...