Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2838543003:
Fix in LayoutTestPermissionManager::RequestPermissions (Closed)
|
Created:
3 years, 8 months ago by Mikhail Modified:
3 years, 8 months ago CC:
chromium-reviews, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix in LayoutTestPermissionManager::RequestPermissions
Resulting vector of statuses must have the same size as the given permissions vector.
Review-Url: https://codereview.chromium.org/2838543003
Cr-Commit-Position: refs/heads/master@{#467263}
Committed: https://chromium.googlesource.com/chromium/src/+/ae42f2708322ae225d1384b2165f5e360a514432
Patch Set 1 #
Messages
Total messages: 18 (11 generated)
The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix in LayoutTestPermissionManager::RequestPermissions Resulting vector of statuses must have the same size as the given permissions vector. ========== to ========== Fix in LayoutTestPermissionManager::RequestPermissions Resulting vector of statuses must have the same size as the given permissions vector. ==========
mikhail.pozdnyakov@intel.com changed reviewers: + mkwst@chromium.org, mlamouri@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mlamouri@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
LGTM.
The CQ bit was checked by mikhail.pozdnyakov@intel.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493192272535710, "parent_rev":
"1d9e0b92b0a9552cd17b3956232842484415da31", "commit_rev":
"ae42f2708322ae225d1384b2165f5e360a514432"}
Message was sent while issue was closed.
Description was changed from ========== Fix in LayoutTestPermissionManager::RequestPermissions Resulting vector of statuses must have the same size as the given permissions vector. ========== to ========== Fix in LayoutTestPermissionManager::RequestPermissions Resulting vector of statuses must have the same size as the given permissions vector. Review-Url: https://codereview.chromium.org/2838543003 Cr-Commit-Position: refs/heads/master@{#467263} Committed: https://chromium.googlesource.com/chromium/src/+/ae42f2708322ae225d1384b2165f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ae42f2708322ae225d1384b2165f... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
