Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(102)

Issue 2838543003: Fix in LayoutTestPermissionManager::RequestPermissions (Closed)

Created:
2 years, 6 months ago by Mikhail
Modified:
2 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix in LayoutTestPermissionManager::RequestPermissions Resulting vector of statuses must have the same size as the given permissions vector. Review-Url: https://codereview.chromium.org/2838543003 Cr-Commit-Position: refs/heads/master@{#467263} Committed: https://chromium.googlesource.com/chromium/src/+/ae42f2708322ae225d1384b2165f5e360a514432

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/shell/browser/layout_test/layout_test_permission_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
Mikhail
PTAL
2 years, 6 months ago (2017-04-25 08:06:28 UTC) #5
mlamouri (slow - plz ping)
lgtm
2 years, 6 months ago (2017-04-25 11:00:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838543003/1
2 years, 6 months ago (2017-04-25 11:00:13 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/419589)
2 years, 6 months ago (2017-04-25 11:07:37 UTC) #12
Mike West
LGTM.
2 years, 6 months ago (2017-04-25 18:35:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838543003/1
2 years, 6 months ago (2017-04-26 07:38:08 UTC) #15
commit-bot: I haz the power
2 years, 6 months ago (2017-04-26 07:41:33 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ae42f2708322ae225d1384b2165f...

Powered by Google App Engine
This is Rietveld 408576698