ScrollAnimatorMac should post contentAreaScrolled only for explicit scrolls.

ScrollAnimatorMac should post contentAreaScrolled only for explicit scrolls.

This is the equivalent of http://crrev.com/2835403002 for the Mac-specific
scrollbar opacity plumbing.

BUG=606395
Review-Url: https://codereview.chromium.org/2838513003
Cr-Commit-Position: refs/heads/master@{#467553}
Committed: https://chromium.googlesource.com/chromium/src/+/e18c551a2e12066dc4a8b0cb026774b824434eff

[skobes, 2017-04-25 02:12:37]

The CQ bit was checked by skobes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 02:13:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 03:55:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 03:56:00]

Dry run: This issue passed the CQ dry run.

[skobes, 2017-04-25 18:38:21]

The CQ bit was checked by skobes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 18:39:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skobes, 2017-04-25 20:34:53]

skobes@chromium.org changed reviewers:
+ bokan@chromium.org, pdr@chromium.org

[commit-bot: I haz the power, 2017-04-25 23:12:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 23:12:49]

Dry run: This issue passed the CQ dry run.

[bokan, 2017-04-25 23:27:38]

This will prevent showing scrollbars on resize, right? Other Mac apps do show
scrollbars when resized, are we ok with breaking the convention?

[skobes, 2017-04-26 01:34:35]

On 2017/04/25 23:27:38, bokan wrote:
> This will prevent showing scrollbars on resize, right? Other Mac apps do show
> scrollbars when resized, are we ok with breaking the convention?

Note that this prevents showing on content area resizes, but still shows on
scroller frame resizes (FrameView::ViewportSizeChanged /
PLSA::VisibleSizeChanged).  So it's pretty hard to notice this as a UI
inconsistency, and I think is outweighed by the benefits of less scrollbar
flashing.

[bokan, 2017-04-26 11:43:31]

ah, lgtm in that case.

[skobes, 2017-04-26 15:55:42]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2017-04-26 15:56:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 16:04:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 16:04:46]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[skobes, 2017-04-26 20:16:31]

(Waiting on pdr for Source/platform OWNERS.)

[pdr., 2017-04-26 20:27:45]

On 2017/04/26 at 20:16:31, skobes wrote:
> (Waiting on pdr for Source/platform OWNERS.)

LGTM

[skobes, 2017-04-26 20:41:11]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2017-04-26 20:41:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 22:43:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 22:43:53]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[skobes, 2017-04-26 23:09:23]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2017-04-26 23:10:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 01:21:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 01:21:23]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[skobes, 2017-04-27 01:32:41]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2017-04-27 01:33:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 02:27:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493256761935650,
"parent_rev": "dfc77e6d1679d209b140a396f131b47ef7d29ab1", "commit_rev":
"e18c551a2e12066dc4a8b0cb026774b824434eff"}

[commit-bot: I haz the power, 2017-04-27 02:27:37]

Description was changed from

==========
ScrollAnimatorMac should post contentAreaScrolled only for explicit scrolls.

This is the equivalent of http://crrev.com/2835403002 for the Mac-specific
scrollbar opacity plumbing.

BUG=606395
==========

to

==========
ScrollAnimatorMac should post contentAreaScrolled only for explicit scrolls.

This is the equivalent of http://crrev.com/2835403002 for the Mac-specific
scrollbar opacity plumbing.

BUG=606395

Review-Url: https://codereview.chromium.org/2838513003
Cr-Commit-Position: refs/heads/master@{#467553}
Committed:
https://chromium.googlesource.com/chromium/src/+/e18c551a2e12066dc4a8b0cb0267...
==========

[commit-bot: I haz the power, 2017-04-27 02:27:38]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e18c551a2e12066dc4a8b0cb0267...

[skobes, 2017-04-27 03:50:33]

On 2017/04/26 01:34:35, skobes wrote:
> Note that this prevents showing on content area resizes, but still shows on
> scroller frame resizes (FrameView::ViewportSizeChanged /
> PLSA::VisibleSizeChanged).  So it's pretty hard to notice this as a UI
> inconsistency, and I think is outweighed by the benefits of less scrollbar
> flashing.

Disregard this, I was mixing up Mac and Aura.

It looks like Chrome on Mac has never shown scrollbars on content resize OR
visible resize.  Safari shows scrollbars for main-frame resize, but not for
content resize or resize of any non-main-frame scroller.  Not sure about
Firefox.

I made a page to test it with: https://output.jsbin.com/jigoyuz

I think we should change Mac to show on all visible-size changes, this would
align with Aura, and with Safari for window resizing.