Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2838483002:
[LayoutNG] Add FlagExpectations for LayoutNG 3/3 (Closed)
Description[LayoutNG] Add FlagExpectations for LayoutNG 3/3
This patch adds the FlagExpectations file for LayoutNG.
The patch is split into 3 CLs because it hits the max limit of CQ.
There are many flaky tests that may need multiple passes until it is
stabilized.
BUG=591099
Review-Url: https://codereview.chromium.org/2838483002
Cr-Commit-Position: refs/heads/master@{#466578}
Committed: https://chromium.googlesource.com/chromium/src/+/7808a9b3588b505c51a35aedde04bfe6bc39fe49
Patch Set 1 #Patch Set 2 : Rebase #
Depends on Patchset: Messages
Total messages: 19 (14 generated)
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== ngbot3 BUG= ========== to ========== [LayoutNG] Add FlagExpectations for LayoutNG 3/3 This patch adds the FlagExpectations file for LayoutNG. The patch is split into 3 CLs because it hits the max limit of CQ. There are many flaky tests that may need multiple passes until it is stabilized. BUG=591099 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ==========
kojii@chromium.org changed reviewers: + eae@chromium.org
PTAL. Hoping this be the last one and to enable CQ_INCLUDE_TRYBOTS in this CL, but maybe not possible yet due to flaky tests.
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
LGTM
Description was changed from ========== [LayoutNG] Add FlagExpectations for LayoutNG 3/3 This patch adds the FlagExpectations file for LayoutNG. The patch is split into 3 CLs because it hits the max limit of CQ. There are many flaky tests that may need multiple passes until it is stabilized. BUG=591099 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ========== to ========== [LayoutNG] Add FlagExpectations for LayoutNG 3/3 This patch adds the FlagExpectations file for LayoutNG. The patch is split into 3 CLs because it hits the max limit of CQ. There are many flaky tests that may need multiple passes until it is stabilized. BUG=591099 ==========
Since there are still some more flaky tests, I'm removing the CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng and land, to add more flaky ones in following CLs.
The CQ bit was checked by kojii@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492999669349810,
"parent_rev": "cf6ef1f8eddd620ccbfc3339aaa34f944462af52", "commit_rev":
"7808a9b3588b505c51a35aedde04bfe6bc39fe49"}
Message was sent while issue was closed.
Description was changed from ========== [LayoutNG] Add FlagExpectations for LayoutNG 3/3 This patch adds the FlagExpectations file for LayoutNG. The patch is split into 3 CLs because it hits the max limit of CQ. There are many flaky tests that may need multiple passes until it is stabilized. BUG=591099 ========== to ========== [LayoutNG] Add FlagExpectations for LayoutNG 3/3 This patch adds the FlagExpectations file for LayoutNG. The patch is split into 3 CLs because it hits the max limit of CQ. There are many flaky tests that may need multiple passes until it is stabilized. BUG=591099 Review-Url: https://codereview.chromium.org/2838483002 Cr-Commit-Position: refs/heads/master@{#466578} Committed: https://chromium.googlesource.com/chromium/src/+/7808a9b3588b505c51a35aedde04... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/7808a9b3588b505c51a35aedde04... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
