Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2838433003:
Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome (Closed)
|
Created:
3 years, 8 months ago by Byoungkwon Ko Modified:
3 years, 7 months ago CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, mac-reviews_chromium.org, dcheng, chromoting-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionReplace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome
BUG=644626
Review-Url: https://codereview.chromium.org/2838433003
Cr-Commit-Position: refs/heads/master@{#470460}
Committed: https://chromium.googlesource.com/chromium/src/+/031e9182682edbd67ddae5c7bd0ba9805bb02146
Patch Set 1 #
Total comments: 2
Patch Set 2 : Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome #Patch Set 3 : Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome #Patch Set 4 : Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome #
Messages
Total messages: 45 (32 generated)
The CQ bit was checked by gogag2@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
gogag2@gmail.com changed reviewers: + chfremer@chromium.org, joedow@chromium.org
PTAL
https://codereview.chromium.org/2838433003/diff/1/remoting/host/clipboard_mac.mm File remoting/host/clipboard_mac.mm (right): https://codereview.chromium.org/2838433003/diff/1/remoting/host/clipboard_mac... remoting/host/clipboard_mac.mm:56: client_clipboard_ = std::move(client_clipboard); Drive-by nit: don't forget to #include <utility> for std::move() here and elsewhere
lgtm (after dcheng's comments have been resolved).
The CQ bit was checked by gogag2@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/04/24 03:36:46, dcheng (OOO through May 2) wrote: > https://codereview.chromium.org/2838433003/diff/1/remoting/host/clipboard_mac.mm > File remoting/host/clipboard_mac.mm (right): > > https://codereview.chromium.org/2838433003/diff/1/remoting/host/clipboard_mac... > remoting/host/clipboard_mac.mm:56: client_clipboard_ = > std::move(client_clipboard); > Drive-by nit: don't forget to #include <utility> for std::move() here and > elsewhere I updated them. Thanks.
https://codereview.chromium.org/2838433003/diff/1/remoting/host/clipboard_mac.mm File remoting/host/clipboard_mac.mm (right): https://codereview.chromium.org/2838433003/diff/1/remoting/host/clipboard_mac... remoting/host/clipboard_mac.mm:56: client_clipboard_ = std::move(client_clipboard); On 2017/04/24 03:36:45, dcheng (OOO through May 2) wrote: > Drive-by nit: don't forget to #include <utility> for std::move() here and > elsewhere I updated the header. Thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by gogag2@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from joedow@chromium.org Link to the patchset: https://codereview.chromium.org/2838433003/#ps20001 (title: "Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
gogag2@gmail.com changed reviewers: + ben@links.org, jam@chromium.org, rockot@google.com
PTAL
lgtm
The CQ bit was checked by gogag2@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from joedow@chromium.org, jam@chromium.org Link to the patchset: https://codereview.chromium.org/2838433003/#ps40001 (title: "Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by gogag2@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by gogag2@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by gogag2@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by gogag2@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from joedow@chromium.org, jam@chromium.org Link to the patchset: https://codereview.chromium.org/2838433003/#ps60001 (title: "Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494384086845320,
"parent_rev": "eddfbeb9499bc63e771b234f1817b67fe88b10d0", "commit_rev":
"031e9182682edbd67ddae5c7bd0ba9805bb02146"}
Message was sent while issue was closed.
Description was changed from ========== Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome BUG=644626 ========== to ========== Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome BUG=644626 Review-Url: https://codereview.chromium.org/2838433003 Cr-Commit-Position: refs/heads/master@{#470460} Committed: https://chromium.googlesource.com/chromium/src/+/031e9182682edbd67ddae5c7bd0b... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/031e9182682edbd67ddae5c7bd0b... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
