Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2838423002: Unbundle opus (Closed)

Created:
3 years, 8 months ago by Paweł Hajdan Jr.
Modified:
3 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Unbundle opus This CL makes it easier for Linux distribution packagers to use system opus codec library, by providing a drop-in replacement GN file. build/linux/unbundle is a separate directory tree, so that regular Chromium developers don't need to worry about this configuration. Please see https://cs.chromium.org/chromium/src/build/linux/unbundle/README?dr for more context. BUG=551343 R=thestig@chromium.org Review-Url: https://codereview.chromium.org/2838423002 . Cr-Commit-Position: refs/heads/master@{#467451} Committed: https://chromium.googlesource.com/chromium/src/+/5e44d52a673058600ca83f0163cded8405c5a8bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
A build/linux/unbundle/opus.gn View 1 chunk +45 lines, -0 lines 0 comments Download
M build/linux/unbundle/replace_gn_files.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Paweł Hajdan Jr.
3 years, 8 months ago (2017-04-26 14:24:02 UTC) #2
Lei Zhang
lgtm
3 years, 8 months ago (2017-04-26 19:19:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838423002/1
3 years, 8 months ago (2017-04-26 19:20:23 UTC) #6
Paweł Hajdan Jr.
3 years, 8 months ago (2017-04-26 20:58:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5e44d52a673058600ca83f0163cded8405c5a8bd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698