Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: third_party/WebKit/Source/core/page/PrintContext.h

Issue 2838343003: Blink Rename follow-up: Rename PrintContext::begin/end to Begin/EndPrintMode. (Closed)
Patch Set: Fix compilation of PrintContextTest.cpp Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/PrintContext.h
diff --git a/third_party/WebKit/Source/core/page/PrintContext.h b/third_party/WebKit/Source/core/page/PrintContext.h
index 6fdfd38055c27c33bb4782aebb668fdd6045fe03..be1b56ccca62c1764a4838009b31591021f4eeac 100644
--- a/third_party/WebKit/Source/core/page/PrintContext.h
+++ b/third_party/WebKit/Source/core/page/PrintContext.h
@@ -48,8 +48,8 @@ class CORE_EXPORT PrintContext
// Break up a page into rects without relayout.
// FIXME: This means that CSS page breaks won't be on page boundary if the
- // size is different than what was passed to begin(). That's probably not
- // always desirable.
+ // size is different than what was passed to BeginPrintMode(). That's probably
+ // not always desirable.
// FIXME: Header and footer height should be applied before layout, not after.
// FIXME: The printRect argument is only used to determine page aspect ratio,
// it would be better to pass a FloatSize with page dimensions instead.
@@ -76,10 +76,10 @@ class CORE_EXPORT PrintContext
// Enter print mode, updating layout for new page size.
// This function can be called multiple times to apply new print options
// without going back to screen mode.
- virtual void begin(float width, float height = 0);
+ virtual void BeginPrintMode(float width, float height = 0);
Łukasz Anforowicz 2017/04/26 22:28:10 |BeginPrintMode| seems like a good name to me, bec
// Return to screen mode.
- virtual void end();
+ virtual void EndPrintMode();
// Used by layout tests.
static int PageNumberForElement(
@@ -112,8 +112,8 @@ class CORE_EXPORT PrintContext
const FloatSize& page_size_in_pixels);
void CollectLinkedDestinations(Node*);
- // Used to prevent misuses of begin() and end() (e.g., call end without
- // begin).
+ // Used to prevent misuses of BeginPrintMode() and EndPrintMode() (e.g., call
+ // EndPrintMode without BeginPrintMode).
bool is_printing_;
HeapHashMap<String, Member<Element>> linked_destinations_;
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp ('k') | third_party/WebKit/Source/core/page/PrintContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698