Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2838263002: [DevTools] Throttle node decorations update in UI (Closed)

Created:
3 years, 8 months ago by dgozman
Modified:
3 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Throttle node decorations update in UI This makes it serialized and skips unnecessary updates with old data. Fixes a bug where marker is not removed when user removes all dom breakpoints from a single dom node. BUG=none Review-Url: https://codereview.chromium.org/2838263002 Cr-Commit-Position: refs/heads/master@{#467410} Committed: https://chromium.googlesource.com/chromium/src/+/83811d039654335fd37aaea3aca170f9c3a377bb

Patch Set 1 #

Patch Set 2 : null check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js View 1 3 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
dgozman
Take a look please.
3 years, 8 months ago (2017-04-26 00:04:32 UTC) #2
pfeldman
lgtm
3 years, 8 months ago (2017-04-26 00:06:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838263002/1
3 years, 8 months ago (2017-04-26 00:16:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/430146)
3 years, 8 months ago (2017-04-26 01:55:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838263002/20001
3 years, 7 months ago (2017-04-26 17:14:24 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-26 19:29:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/83811d039654335fd37aaea3aca1...

Powered by Google App Engine
This is Rietveld 408576698