Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2838213002: [ObjC ARC] Converts ios/chrome/browser/ui/fancy_ui:fancy_ui to ARC. (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 7 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/fancy_ui:fancy_ui to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2838213002 Cr-Commit-Position: refs/heads/master@{#467940} Committed: https://chromium.googlesource.com/chromium/src/+/cf0a0e0b2a1745946df52a63c7b85107f44a2c0c

Patch Set 1 #

Patch Set 2 : Moving ivar from .h to .mm #

Patch Set 3 : Remove scoped object header #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -26 lines) Patch
M ios/chrome/browser/ui/fancy_ui/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/fancy_ui/bidi_container_view.h View 1 2 1 chunk +1 line, -16 lines 0 comments Download
M ios/chrome/browser/ui/fancy_ui/bidi_container_view.mm View 1 2 chunks +18 lines, -2 lines 1 comment Download
M ios/chrome/browser/ui/fancy_ui/primary_action_button.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/fancy_ui/tinted_button.mm View 3 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
gambard
PTAL
3 years, 8 months ago (2017-04-25 16:52:43 UTC) #5
gambard
+sdefresne: PTAL.
3 years, 7 months ago (2017-04-27 15:47:31 UTC) #14
rohitrao (ping after 24h)
lgtm
3 years, 7 months ago (2017-04-28 07:36:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838213002/40001
3 years, 7 months ago (2017-04-28 08:03:26 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/cf0a0e0b2a1745946df52a63c7b85107f44a2c0c
3 years, 7 months ago (2017-04-28 09:12:49 UTC) #20
sdefresne
3 years, 7 months ago (2017-04-28 10:21:31 UTC) #21
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/2838213002/diff/40001/ios/chrome/browser/ui/f...
File ios/chrome/browser/ui/fancy_ui/bidi_container_view.mm (right):

https://codereview.chromium.org/2838213002/diff/40001/ios/chrome/browser/ui/f...
ios/chrome/browser/ui/fancy_ui/bidi_container_view.mm:25: NSMutableSet*
subviewsToBeAdjustedForRTL_;
nit: NSMutableSet<UIView*>* subviewsToBeAdjustedForRTL_;

Powered by Google App Engine
This is Rietveld 408576698