Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 2838193004: [Web Payments] Implement placeholders in the shipping options row (Closed)

Created:
3 years, 8 months ago by anthonyvd
Modified:
3 years, 8 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, gogerald+paymentswatch_chromium.org, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Web Payments] Implement placeholders in the shipping options row BUG=710977 Review-Url: https://codereview.chromium.org/2838193004 Cr-Commit-Position: refs/heads/master@{#467385} Committed: https://chromium.googlesource.com/chromium/src/+/55cde5fb732692857b3535076e5ac9e08188033e

Patch Set 1 #

Patch Set 2 : Refactor row creation. #

Patch Set 3 : Remove unused variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -254 lines) Patch
M chrome/browser/ui/views/payments/payment_sheet_view_controller.cc View 1 2 11 chunks +210 lines, -254 lines 0 comments Download
M components/payments_strings.grdp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
anthonyvd
Hi Math, PTAL! :) This change also refactors the row creation code that was getting ...
3 years, 8 months ago (2017-04-26 17:07:23 UTC) #8
Mathieu
bellissimo! (or, lgtm)
3 years, 8 months ago (2017-04-26 17:29:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838193004/40001
3 years, 8 months ago (2017-04-26 17:37:01 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 18:27:38 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/55cde5fb732692857b3535076e5a...

Powered by Google App Engine
This is Rietveld 408576698