Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3667)

Issue 2838153002: Make most of CSP code work with non-Document ExecutionContext (Closed)

Created:
2 years, 4 months ago by kinuko
Modified:
2 years, 4 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, horo, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make most of CSP code work with non-Document ExecutionContext BUG=695279 Review-Url: https://codereview.chromium.org/2838153002 Cr-Commit-Position: refs/heads/master@{#467307} Committed: https://chromium.googlesource.com/chromium/src/+/ebd1c7d184fd1979b0eb0590665fe2695fc353f7

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -92 lines) Patch
M third_party/WebKit/Source/core/dom/SecurityContext.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 1 1 chunk +34 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp View 1 30 chunks +73 lines, -65 lines 0 comments Download
M third_party/WebKit/Source/core/testing/NullExecutionContext.h View 1 3 chunks +8 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/testing/NullExecutionContext.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (18 generated)
kinuko
I believe in most cases all it needs is either SecurityContext or ExecutionContext, but not ...
2 years, 4 months ago (2017-04-26 07:33:40 UTC) #13
Mike West
Looks good, and the bots are still happy. LGTM!
2 years, 4 months ago (2017-04-26 09:20:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838153002/40001
2 years, 4 months ago (2017-04-26 12:42:19 UTC) #19
commit-bot: I haz the power
2 years, 4 months ago (2017-04-26 12:48:04 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ebd1c7d184fd1979b0eb0590665f...

Powered by Google App Engine
This is Rietveld 408576698