[turbofan] Fix lowering of Array constructor with one argument.

[turbofan] Fix lowering of Array constructor with one argument.

Only create a singleton array for Array(len) if Type(len) cannot be
Number, otherwise we might need to throw an exception instead.

BUG=chromium:715404
R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2838123004
Cr-Commit-Position: refs/heads/master@{#44886}
Committed: https://chromium.googlesource.com/v8/v8/+/d06d4ce2c4b36d722d4cb788c3962b4e92ab7a47

[Benedikt Meurer, 2017-04-26 11:36:55]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 11:37:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2017-04-26 11:40:41]

lgtm

[Benedikt Meurer, 2017-04-26 11:41:27]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2017-04-26 11:41:30]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2017-04-26 11:41:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 12:02:13]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493206890091020, "parent_rev":
"9deed4095d7ee2a229a37c3e84987cc158b82c61", "commit_rev":
"d06d4ce2c4b36d722d4cb788c3962b4e92ab7a47"}

[commit-bot: I haz the power, 2017-04-26 12:02:20]

Description was changed from

==========
[turbofan] Fix lowering of Array constructor with one argument.

Only create a singleton array for Array(len) if Type(len) cannot be
Number, otherwise we might need to throw an exception instead.

BUG=chromium:715404
R=jarin@chromium.org
==========

to

==========
[turbofan] Fix lowering of Array constructor with one argument.

Only create a singleton array for Array(len) if Type(len) cannot be
Number, otherwise we might need to throw an exception instead.

BUG=chromium:715404
R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2838123004
Cr-Commit-Position: refs/heads/master@{#44886}
Committed:
https://chromium.googlesource.com/v8/v8/+/d06d4ce2c4b36d722d4cb788c3962b4e92a...
==========

[commit-bot: I haz the power, 2017-04-26 12:02:21]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d06d4ce2c4b36d722d4cb788c3962b4e92a...

[Michael Achenbach, 2017-04-26 12:36:07]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2017-04-26 12:36:08]

https://codereview.chromium.org/2838123004/diff/1/src/compiler/js-create-lowe...
File src/compiler/js-create-lowering.cc (right):

https://codereview.chromium.org/2838123004/diff/1/src/compiler/js-create-lowe...
src/compiler/js-create-lowering.cc:821: return ReduceNewArray(node, {length},
site);
Are you sure this code is covered? Sancov bot shows a red mark here, gcov is
still working, lets see:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20gcov%20cov...

[Michael Achenbach, 2017-04-26 13:43:32]

No coverage on gcov either:
https://storage.googleapis.com/chromium-v8/linux64_gcov_rel/44b291d0e21e75395...

[Benedikt Meurer, 2017-04-26 16:24:15]

On 2017/04/26 13:43:32, Michael Achenbach wrote:
> No coverage on gcov either:
>
https://storage.googleapis.com/chromium-v8/linux64_gcov_rel/44b291d0e21e75395...

Cool, thanks. I'll add a test.