Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 2838063002: [on-hold][subresource_filter] Add ActivationTracker to track all activated contents (Closed)

Created:
6 months, 3 weeks ago by Charlie Harrison
Modified:
6 months, 1 week ago
Reviewers:
shivanisha
CC:
chromium-reviews, darin-cc_chromium.org, jam, subresource-filter-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[subresource_filter] Add ActivationTracker to track all activated contents This allows us to determine if a given site is activated in the current profile, taking into account all of the WebContents that the profile is hosting. This will be used to hook into preferences, which are mostly scoped on a per-profile basis. BUG=todo

Patch Set 1 #

Patch Set 2 : add files #

Patch Set 3 : refactor #

Patch Set 4 : fix incognito #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -19 lines) Patch
M chrome/browser/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/subresource_filter/chrome_subresource_filter_client.h View 1 2 4 chunks +15 lines, -2 lines 0 comments Download
M chrome/browser/subresource_filter/chrome_subresource_filter_client.cc View 1 2 7 chunks +38 lines, -8 lines 0 comments Download
A chrome/browser/subresource_filter/subresource_filter_activation_tracker.h View 1 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/browser/subresource_filter/subresource_filter_activation_tracker.cc View 1 1 chunk +32 lines, -0 lines 0 comments Download
M chrome/browser/subresource_filter/subresource_filter_browsertest.cc View 1 2 3 3 chunks +77 lines, -0 lines 0 comments Download
M chrome/browser/subresource_filter/subresource_filter_content_settings_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/subresource_filter/subresource_filter_profile_context.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/subresource_filter/subresource_filter_profile_context.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/subresource_filter/subresource_filter_profile_context_factory.h View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/subresource_filter/subresource_filter_profile_context_factory.cc View 1 2 3 2 chunks +11 lines, -3 lines 0 comments Download
M components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M components/subresource_filter/content/browser/subresource_filter_client.h View 1 2 3 chunks +9 lines, -3 lines 0 comments Download
M components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (16 generated)
Charlie Harrison
shivanisha: could you take a first look?
6 months, 3 weeks ago (2017-04-30 13:16:55 UTC) #17
Charlie Harrison
6 months, 2 weeks ago (2017-05-01 04:08:51 UTC) #18
Actually, hold off the requirements may be changing.

Powered by Google App Engine
This is Rietveld efc10ee0f