Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2838043002: [ES6 modules] Introduce ModuleScript::CreateInstantiationError (Closed)

Created:
3 years, 7 months ago by kouhei (in TOK)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ES6 modules] Introduce ModuleScript::CreateInstantiationError This CL introduces ModuleScript::CreateInstantiationError member func, which serves as a getter for instantiation_error_. This is split from hiroshige@'s CL: https://codereview.chromium.org/2819733002/ AUTHOR=hiroshige@chromium.org BUG=594639 Review-Url: https://codereview.chromium.org/2838043002 Cr-Commit-Position: refs/heads/master@{#466887} Committed: https://chromium.googlesource.com/chromium/src/+/702de0adbf42af51c93feabf9c46cdad25dc7862

Patch Set 1 #

Patch Set 2 : revert const change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/ModuleScript.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
kouhei (in TOK)
3 years, 7 months ago (2017-04-25 01:24:22 UTC) #2
nhiroki
LGTM nit: s/introduce/introduces/ in the CL description
3 years, 7 months ago (2017-04-25 01:26:51 UTC) #3
kouhei (in TOK)
On 2017/04/25 01:26:51, nhiroki wrote: > LGTM > > nit: s/introduce/introduces/ in the CL description ...
3 years, 7 months ago (2017-04-25 01:28:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838043002/20001
3 years, 7 months ago (2017-04-25 01:28:42 UTC) #7
hiroshige
lgtm
3 years, 7 months ago (2017-04-25 01:47:53 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-04-25 05:27:05 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/702de0adbf42af51c93feabf9c46...

Powered by Google App Engine
This is Rietveld 408576698