Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2838013005: Update CSSSelectorParserTest so that it doesn't test /deep/ nor ::shadow (Closed)

Created:
3 years, 8 months ago by hayato
Modified:
3 years, 8 months ago
Reviewers:
tkent, kochi
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update CSSSelectorParserTest so that it doesn't test /deep/ nor ::shadow BUG=715440 Review-Url: https://codereview.chromium.org/2838013005 Cr-Commit-Position: refs/heads/master@{#467284} Committed: https://chromium.googlesource.com/chromium/src/+/33930987a0aa0ad3c44c8d13019e05a417d64d6a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSSelectorParserTest.cpp View 4 chunks +4 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
hayato
PTAL
3 years, 8 months ago (2017-04-26 08:31:46 UTC) #4
kochi
lgtm
3 years, 8 months ago (2017-04-26 10:15:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838013005/1
3 years, 8 months ago (2017-04-26 10:15:28 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 10:19:48 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/33930987a0aa0ad3c44c8d13019e...

Powered by Google App Engine
This is Rietveld 408576698