diagnose_apk_bloat.py: add native diffs.

diagnose_apk_bloat.py: add native diffs.

This CL adds native diffing to diagnose_apk_bloat.py via
tools/binary_size/supersize.

The summary section just shows the changes in section sizes and the
details section gives the output of diffing two SizeInfo objects.

BUG=695182
Review-Url: https://codereview.chromium.org/2837953002
Cr-Commit-Position: refs/heads/master@{#466807}
Committed: https://chromium.googlesource.com/chromium/src/+/7c20807c1c9b2b2252bf102b8316b17e94ca8a57

[estevenson, 2017-04-24 20:12:08]

estevenson@chromium.org changed reviewers:
+ agrieve@chromium.org

[estevenson, 2017-04-24 20:12:09]

ptal Andrew. The summary regex is pretty fragile - not sure about a better way
to get that info without adding an API to supersize for it though.

[agrieve, 2017-04-24 20:43:21]

lgtm

https://codereview.chromium.org/2837953002/diff/20001/tools/binary_size/diagn...
File tools/binary_size/diagnose_apk_bloat.py (right):

https://codereview.chromium.org/2837953002/diff/20001/tools/binary_size/diagn...
tools/binary_size/diagnose_apk_bloat.py:98: q = 'Print(Diff(size_info1,
size_info2), use_pager=False);'
nit: shouldn't need to specify use_pager=False. It should default to false if it
detects the output is being piped.

[estevenson, 2017-04-24 22:38:48]

The CQ bit was checked by estevenson@chromium.org

[estevenson, 2017-04-24 22:38:50]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2837953002/#ps40001
(title: "console -> diff + log file format fix")

[estevenson, 2017-04-24 22:39:40]

https://codereview.chromium.org/2837953002/diff/20001/tools/binary_size/diagn...
File tools/binary_size/diagnose_apk_bloat.py (right):

https://codereview.chromium.org/2837953002/diff/20001/tools/binary_size/diagn...
tools/binary_size/diagnose_apk_bloat.py:98: q = 'Print(Diff(size_info1,
size_info2), use_pager=False);'
On 2017/04/24 20:43:21, agrieve wrote:
> nit: shouldn't need to specify use_pager=False. It should default to false if
it
> detects the output is being piped.

Switched to diff instead of console. Done.

[commit-bot: I haz the power, 2017-04-24 22:39:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 22:52:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493073528405440,
"parent_rev": "d623444f8f4423798526f5f596ab10d892b74308", "commit_rev":
"7c20807c1c9b2b2252bf102b8316b17e94ca8a57"}

[commit-bot: I haz the power, 2017-04-24 22:52:25]

Description was changed from

==========
diagnose_apk_bloat.py: add native diffs.

This CL adds native diffing to diagnose_apk_bloat.py via
tools/binary_size/supersize.

The summary section just shows the changes in section sizes and the
details section gives the output of diffing two SizeInfo objects.

BUG=695182
==========

to

==========
diagnose_apk_bloat.py: add native diffs.

This CL adds native diffing to diagnose_apk_bloat.py via
tools/binary_size/supersize.

The summary section just shows the changes in section sizes and the
details section gives the output of diffing two SizeInfo objects.

BUG=695182

Review-Url: https://codereview.chromium.org/2837953002
Cr-Commit-Position: refs/heads/master@{#466807}
Committed:
https://chromium.googlesource.com/chromium/src/+/7c20807c1c9b2b2252bf102b8316...
==========

[commit-bot: I haz the power, 2017-04-24 22:52:30]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7c20807c1c9b2b2252bf102b8316...