Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 2837943003: DevTools: trim the leading BOM char when parsing web manifest. (Closed)

Created:
3 years, 8 months ago by pfeldman
Modified:
3 years, 8 months ago
Reviewers:
paulirish
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: trim the leading BOM char when parsing web manifest. BUG=706926 Review-Url: https://codereview.chromium.org/2837943003 Cr-Commit-Position: refs/heads/master@{#466886} Committed: https://chromium.googlesource.com/chromium/src/+/ab0ffaa4b4181f089c428c8f474e14eddc353b73

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
pfeldman
3 years, 8 months ago (2017-04-25 00:28:25 UTC) #2
paulirish
lgtm
3 years, 8 months ago (2017-04-25 00:33:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837943003/1
3 years, 8 months ago (2017-04-25 00:33:52 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 05:26:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ab0ffaa4b4181f089c428c8f474e...

Powered by Google App Engine
This is Rietveld 408576698