third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp - Issue 2837923003: Make NodeFilter a legacy callback interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp

Issue 2837923003: Make NodeFilter a legacy callback interface. (Closed)

Patch Set: legacy_callback_interface.*.tmpl, etc. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/templates/legacy_callback_interface.cpp.tmpl ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8TestLegacyCallbackInterface.cpp ('k') | third_party/WebKit/Source/core/dom/NodeFilter.h » ('j') | third_party/WebKit/Source/core/dom/NodeFilter.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp

index 4b15cd3b5e7197ecb57de2860dea4edaf55831cf..3b397bfa2b03c47404ebe0579e72198e1909b3ff 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp

@@ -791,7 +791,7 @@ static void nodeFilterAttributeAttributeSetter(v8::Local<v8::Value> v8Value, con

TestObject* impl = V8TestObject::toImpl(holder);

// Prepare the value to be set.

- V8NodeFilterCondition* cppValue = V8NodeFilterCondition::CreateOrNull(v8Value, ScriptState::Current(info.GetIsolate()));

+ V8NodeFilterCondition* cppValue = V8NodeFilter::toImplWithTypeCheck(info.GetIsolate(), v8Value);

impl->setNodeFilterAttribute(cppValue);

}