Chromium Code Reviews| Index: third_party/WebKit/Source/core/dom/NodeFilter.idl |
| diff --git a/third_party/WebKit/Source/core/dom/NodeFilter.idl b/third_party/WebKit/Source/core/dom/NodeFilter.idl |
| index e9dc637aaa12681e5111ed7e2eaf9df26122045e..bde7982d522eca94a0e93fc178ecee3b8097d5a8 100644 |
| --- a/third_party/WebKit/Source/core/dom/NodeFilter.idl |
| +++ b/third_party/WebKit/Source/core/dom/NodeFilter.idl |
| @@ -20,10 +20,9 @@ |
| // https://dom.spec.whatwg.org/#interface-nodefilter |
| -// FIXME: NodeFilter should be a callback interface. crbug.com/462946 |
| [ |
| DependentLifetime, |
| -] interface NodeFilter { |
| +] callback interface NodeFilter { |
| // Constants for acceptNode() |
| const unsigned short FILTER_ACCEPT = 1; |
| const unsigned short FILTER_REJECT = 2; |
| @@ -44,6 +43,9 @@ |
| const unsigned long SHOW_DOCUMENT_FRAGMENT = 0x400; |
| const unsigned long SHOW_NOTATION = 0x800; // historical |
| + // This function declaration doesn't generate any code because |
| + // V8NodeFilterCondition represents this callback interface in Blink. |
| + // TODO(tkent): Fix crbug.com/630986 |
|
bashi
2017/04/28 06:28:34
Also feel free to assign this to me if fixing 6309
|
| // FIXME: The node argument should not be optional. |
| - [RaisesException, LegacyInterfaceTypeChecking] unsigned short acceptNode([Default=Undefined] optional Node node); |
| + [RaisesException] unsigned short acceptNode([Default=Undefined] optional Node node); |
| }; |