Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py

Issue 2837923003: Make NodeFilter a legacy callback interface. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py
diff --git a/third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py b/third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py
index 4b759de70f90b8d283eae07a8b85645590db56dc..04e4e0e36c83b38af6c7a54c51973c7ecb7ee642 100755
--- a/third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py
+++ b/third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py
@@ -30,7 +30,7 @@ from utilities import get_file_contents
from utilities import get_interface_exposed_arguments
from utilities import get_interface_extended_attributes_from_idl
from utilities import idl_filename_to_interface_name
-from utilities import is_callback_interface_from_idl
+from utilities import is_non_legacy_callback_interface_from_idl
from utilities import read_file_to_list
from utilities import read_pickle_file
from utilities import should_generate_impl_file_from_idl
@@ -79,11 +79,9 @@ def record_global_constructors(idl_filename):
# An interface property is produced for every non-callback interface
# that does not have [NoInterfaceObject].
- # Callback interfaces with constants also have interface properties,
- # but there are none of these in Blink.
# http://heycam.github.io/webidl/#es-interfaces
if ((not should_generate_impl_file_from_idl(idl_file_contents)) or
- is_callback_interface_from_idl(idl_file_contents) or
+ is_non_legacy_callback_interface_from_idl(idl_file_contents) or
'NoInterfaceObject' in extended_attributes):
return

Powered by Google App Engine
This is Rietveld 408576698