Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/global-constructors.html

Issue 2837923003: Make NodeFilter a legacy callback interface. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/global-constructors.html
diff --git a/third_party/WebKit/LayoutTests/fast/dom/global-constructors.html b/third_party/WebKit/LayoutTests/fast/dom/global-constructors.html
index 7b7d59ab766e47be8151b07ca107c4a89651fa4e..d1d6ce42c173a66179280094487107dfd4a67371 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/global-constructors.html
+++ b/third_party/WebKit/LayoutTests/fast/dom/global-constructors.html
@@ -78,11 +78,6 @@ function test()
xpathresult = xpathevaluator.evaluate('/', document, null, 0, null);
shouldBe("window.XPathResult.prototype.isPrototypeOf(xpathresult)", true);
- try {
- nodeFilter = document.createNodeIterator(document, NodeFilter.SHOW_ELEMENT, function () {}, false).filter;
- } catch(e) {}
- shouldBe("window.NodeFilter.prototype.isPrototypeOf(nodeFilter)", false);
bashi 2017/04/27 08:49:49 Could you elaborate why removing this is fine? Sho
tkent 2017/04/27 09:15:12 Now window.NodeFilter.prototype is undefined, and
-
originalNodePrototype = window.Node.prototype;
deleteResult = delete window.Node.prototype;

Powered by Google App Engine
This is Rietveld 408576698