Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 2837893002: Wires up InputDeviceClient for mash/mushrome (Closed)

Created:
3 years, 8 months ago by sky
Modified:
3 years, 8 months ago
Reviewers:
kylechar
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Wires up InputDeviceClient for mash/mushrome Classic ash gets InputDeviceClient by way of creating OzonePlatform. Mushrome, when run from chrome --mus gets InputDeviceClient by way of Chrome explicitly creating it. This means in tests run in MUS mode the test harness needs to create InputDeviceClient. WindowManager when run in MASH mode needs to create InputDeviceClient too. BUG=712290 TEST=covered by tests R=kylechar@chromium.org Review-Url: https://codereview.chromium.org/2837893002 Cr-Commit-Position: refs/heads/master@{#466743} Committed: https://chromium.googlesource.com/chromium/src/+/83b1bb154f0fcf2f3ecb5b28f1d76994d0d13b46

Patch Set 1 #

Patch Set 2 : comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -9 lines) Patch
M ash/mus/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ash/mus/test/wm_test_helper.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ash/mus/test/wm_test_helper.cc View 3 chunks +10 lines, -1 line 0 comments Download
M ash/mus/window_manager.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ash/mus/window_manager.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ash/shell.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M ash/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ash/test/ash_test_helper.h View 3 chunks +5 lines, -2 lines 0 comments Download
M ash/test/ash_test_helper.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/filters/ash_mus_unittests.filter View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 11 (7 generated)
sky
https://codereview.chromium.org/2837893002/diff/20001/testing/buildbot/filters/ash_mus_unittests.filter File testing/buildbot/filters/ash_mus_unittests.filter (right): https://codereview.chromium.org/2837893002/diff/20001/testing/buildbot/filters/ash_mus_unittests.filter#newcode395 testing/buildbot/filters/ash_mus_unittests.filter:395: -WorkspaceLayoutManagerTest.SizeToWorkArea These need to be disabled because the tests ...
3 years, 8 months ago (2017-04-24 17:09:10 UTC) #1
kylechar
lgtm
3 years, 8 months ago (2017-04-24 18:44:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837893002/20001
3 years, 8 months ago (2017-04-24 19:07:49 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 20:29:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/83b1bb154f0fcf2f3ecb5b28f1d7...

Powered by Google App Engine
This is Rietveld 408576698