Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2837873006:
Re-enable formerly flaky tests for the PrerenderingOffliner. (Closed)
|
Created:
3 years, 8 months ago by Pete Williamson Modified:
3 years, 7 months ago Reviewers:
dewittj CC:
chromium-reviews, cbentzel+watch_chromium.org, dewittj+watch_chromium.org, tburkard+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, gavinp+prer_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRe-enable formerly flaky tests for the PrerenderingOffliner.
A Sheriff disabled these tests when they were found to be flaky.
I've fixed two problems, an uninitialized pointer which might have
been causing a crash (previous changelist), and in this changelist
a missing call to PumpLoop() causing the test to fail when
race conditions happened.
BUG=712941
Review-Url: https://codereview.chromium.org/2837873006
Cr-Commit-Position: refs/heads/master@{#467765}
Committed: https://chromium.googlesource.com/chromium/src/+/4ab7eea2c4f7ee425a2c38ceab1a84be2fc27daf
Patch Set 1 #
Total comments: 4
Patch Set 2 : Comment fix #Patch Set 3 : More comment clarification #Messages
Total messages: 22 (14 generated)
petewil@chromium.org changed reviewers: + dewittj@chromium.org
DewittJ - Please take a look at this unit test re-enable.
The CQ bit was checked by dewittj@chromium.org to run a CQ dry run
https://codereview.chromium.org/2837873006/diff/1/chrome/browser/android/offl... File chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc (right): https://codereview.chromium.org/2837873006/diff/1/chrome/browser/android/offl... chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc:450: // Wait until callback arrives before checking postconditions. Which callback? https://codereview.chromium.org/2837873006/diff/1/chrome/browser/android/offl... chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc:471: // Wait until callback arrives before checking postconditions. same
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by petewil@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Updated comments to clarify which callback is being called https://codereview.chromium.org/2837873006/diff/1/chrome/browser/android/offl... File chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc (right): https://codereview.chromium.org/2837873006/diff/1/chrome/browser/android/offl... chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc:450: // Wait until callback arrives before checking postconditions. On 2017/04/27 17:30:52, dewittj wrote: > Which callback? Done. https://codereview.chromium.org/2837873006/diff/1/chrome/browser/android/offl... chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc:471: // Wait until callback arrives before checking postconditions. On 2017/04/27 17:30:52, dewittj wrote: > same Done.
There is no obvious completion callback here, that's why I was confused. I think you should describe the operation that needs to run. something like "Asynchronous cancel operation needs to complete"
The CQ bit was checked by petewil@chromium.org to run a CQ dry run
On 2017/04/27 18:17:08, dewittj wrote: > There is no obvious completion callback here, that's why I was confused. I > think you should describe the operation that needs to run. something like > "Asynchronous cancel operation needs to complete" OK, I commented on the LoadAndSave method, see if that makes it clear. Thanks!
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by petewil@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493321900965020,
"parent_rev": "84f22bee5f4c1146e0f357378b3c4cd6a8294123", "commit_rev":
"4ab7eea2c4f7ee425a2c38ceab1a84be2fc27daf"}
Message was sent while issue was closed.
Description was changed from ========== Re-enable formerly flaky tests for the PrerenderingOffliner. A Sheriff disabled these tests when they were found to be flaky. I've fixed two problems, an uninitialized pointer which might have been causing a crash (previous changelist), and in this changelist a missing call to PumpLoop() causing the test to fail when race conditions happened. BUG=712941 ========== to ========== Re-enable formerly flaky tests for the PrerenderingOffliner. A Sheriff disabled these tests when they were found to be flaky. I've fixed two problems, an uninitialized pointer which might have been causing a crash (previous changelist), and in this changelist a missing call to PumpLoop() causing the test to fail when race conditions happened. BUG=712941 Review-Url: https://codereview.chromium.org/2837873006 Cr-Commit-Position: refs/heads/master@{#467765} Committed: https://chromium.googlesource.com/chromium/src/+/4ab7eea2c4f7ee425a2c38ceab1a... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/4ab7eea2c4f7ee425a2c38ceab1a... |
