Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2837793003:
Minor comment on the chrome://settings/passwords (Closed)
|
Created:
3 years, 8 months ago by vasilii Modified:
3 years, 8 months ago Reviewers:
Dan Beam CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org, hcarmona Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMinor comment on the chrome://settings/passwords
This is a follow-up to https://codereview.chromium.org/2805683002/
BUG=706310
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2837793003
Cr-Commit-Position: refs/heads/master@{#467282}
Committed: https://chromium.googlesource.com/chromium/src/+/a7695ef873dfa0530d2ea4c1088e2fb67719607a
Patch Set 1 #
Total comments: 2
Patch Set 2 : comment #Messages
Total messages: 23 (15 generated)
Description was changed from ========== Minor comment on the chrome://settings/passwords This is a follow-up to https://codereview.chromium.org/2805683002/ BUG=706310 ========== to ========== Minor comment on the chrome://settings/passwords This is a follow-up to https://codereview.chromium.org/2805683002/ BUG=706310 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by vasilii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
vasilii@chromium.org changed reviewers: + dbeam@chromium.org
Hi Dan, please review
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
https://codereview.chromium.org/2837793003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html (right): https://codereview.chromium.org/2837793003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:129: {{item.federationText}} here, too {{...}} -> [[...]]
The CQ bit was checked by vasilii@chromium.org to run a CQ dry run
https://codereview.chromium.org/2837793003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html (right): https://codereview.chromium.org/2837793003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:129: {{item.federationText}} On 2017/04/24 19:45:11, Dan Beam wrote: > here, too > > {{...}} -> [[...]] Done.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by vasilii@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by vasilii@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493197273723840,
"parent_rev": "d9b19c661ed366be0c901cc45257160986bab530", "commit_rev":
"a7695ef873dfa0530d2ea4c1088e2fb67719607a"}
Message was sent while issue was closed.
Description was changed from ========== Minor comment on the chrome://settings/passwords This is a follow-up to https://codereview.chromium.org/2805683002/ BUG=706310 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Minor comment on the chrome://settings/passwords This is a follow-up to https://codereview.chromium.org/2805683002/ BUG=706310 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2837793003 Cr-Commit-Position: refs/heads/master@{#467282} Committed: https://chromium.googlesource.com/chromium/src/+/a7695ef873dfa0530d2ea4c1088e... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/a7695ef873dfa0530d2ea4c1088e... |
