Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2837773004: Make GPU_CLIENT_DCHECK_CODE_BLOCK obey DCHECK_ALWAYS_ON. (Closed)

Created:
3 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
3 years, 8 months ago
Reviewers:
vmiura
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make GPU_CLIENT_DCHECK_CODE_BLOCK obey DCHECK_ALWAYS_ON. Note that this block of #ifdefs violates the indentation guidelines, but I'm ignoring that because the current form is more readable. BUG=714761 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2837773004 Cr-Commit-Position: refs/heads/master@{#466790} Committed: https://chromium.googlesource.com/chromium/src/+/88c1201998461775ec1c604baa77c25c8023af8c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M gpu/command_buffer/client/gles2_implementation.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Ken Russell (switch to Gerrit)
PTAL
3 years, 8 months ago (2017-04-24 21:00:40 UTC) #3
vmiura
lgtm
3 years, 8 months ago (2017-04-24 21:02:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837773004/1
3 years, 8 months ago (2017-04-24 21:03:23 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 22:13:09 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/88c1201998461775ec1c604baa77...

Powered by Google App Engine
This is Rietveld 408576698