webkitpy: Check xvfb with xdpyinfo after starting.

webkitpy: Check xvfb with xdpyinfo after starting.

This makes sure that xvfb actually started correctly and you can connect
to it. We don't use -display argument as we want to make sure the
environment is correct.

BUG=713597
Review-Url: https://codereview.chromium.org/2837773002
Cr-Commit-Position: refs/heads/master@{#467253}
Committed: https://chromium.googlesource.com/chromium/src/+/dcdb807ced40e620460ccf56362945e6860db1ab

[mithro, 2017-04-24 06:15:05]

tansell@chromium.org changed reviewers:
+ mcgreevy@chromium.org, qyearsley@chromium.org

[mithro, 2017-04-26 01:45:35]

Description was changed from

==========
webkitpy: Check xvfb with xdpyinfo after starting.

This makes sure that xvfb actually started correctly and you can connect
to it. We don't use -display argument as we want to make sure the
environment is correct.

BUG=713597
==========

to

==========
webkitpy: Check xvfb with xdpyinfo after starting.

This makes sure that xvfb actually started correctly and you can connect
to it. We don't use -display argument as we want to make sure the
environment is correct.

BUG=713597
==========

[mithro, 2017-04-26 01:45:35]

tansell@chromium.org changed reviewers:
+ dpranke@google.com

[mithro, 2017-04-26 01:45:50]

The CQ bit was checked by tansell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 01:46:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mithro, 2017-04-26 02:16:39]

The CQ bit was checked by tansell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 02:17:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2017-04-26 02:19:17]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2017-04-26 02:19:18]

lgtm

https://codereview.chromium.org/2837773002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py
(right):

https://codereview.chromium.org/2837773002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py:51:
XVFB_START_TIMEOUT = 30.0  # Wait up to 30 seconds for Xvfb to start.
This seems way too long to wait in general, given that it should be subsecond,
but I'm fine w/ it for now for debugging purposes.

[mithro, 2017-04-26 02:21:52]

tansell@chromium.org changed reviewers:
- dpranke@chromium.org

[mithro, 2017-04-26 02:21:53]

Hi Dirk,

PTAL.

Tim 'mithro' Ansell

[commit-bot: I haz the power, 2017-04-26 03:00:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 03:00:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mithro, 2017-04-26 03:11:50]

The CQ bit was checked by tansell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 03:12:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mithro, 2017-04-26 03:13:26]

Patchset #2 (id:20001) has been deleted

[mithro, 2017-04-26 03:14:05]

The CQ bit was checked by tansell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 03:14:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mithro, 2017-04-26 03:39:00]

The CQ bit was checked by tansell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 03:39:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mithro, 2017-04-26 05:06:15]

The CQ bit was unchecked by tansell@chromium.org

[mithro, 2017-04-26 05:06:20]

The CQ bit was checked by tansell@chromium.org

[mithro, 2017-04-26 05:06:20]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2837773002/#ps80001
(title: "Fixing tests")

[commit-bot: I haz the power, 2017-04-26 05:06:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 06:30:06]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493183180242120,
"parent_rev": "bd0fcfc50787bed5d42f1c8fab247234c1a6a20e", "commit_rev":
"dcdb807ced40e620460ccf56362945e6860db1ab"}

[commit-bot: I haz the power, 2017-04-26 06:30:14]

Description was changed from

==========
webkitpy: Check xvfb with xdpyinfo after starting.

This makes sure that xvfb actually started correctly and you can connect
to it. We don't use -display argument as we want to make sure the
environment is correct.

BUG=713597
==========

to

==========
webkitpy: Check xvfb with xdpyinfo after starting.

This makes sure that xvfb actually started correctly and you can connect
to it. We don't use -display argument as we want to make sure the
environment is correct.

BUG=713597

Review-Url: https://codereview.chromium.org/2837773002
Cr-Commit-Position: refs/heads/master@{#467253}
Committed:
https://chromium.googlesource.com/chromium/src/+/dcdb807ced40e620460ccf563629...
==========

[commit-bot: I haz the power, 2017-04-26 06:30:15]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/dcdb807ced40e620460ccf563629...

[qyearsley, 2017-05-08 17:19:47]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org
- dpranke@google.com

[qyearsley, 2017-05-08 17:19:47]

LGTM, thanks.

I would have had a couple minor nits (nested ifs could be changed to `and`, typo
in test method name), but these are not important.