Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2837753002: [marge-m59] Add "mark promise as handled" change to pipeThrough() (Closed)

Created:
3 years, 8 months ago by Adam Rice
Modified:
3 years, 8 months ago
CC:
chromium-reviews, blink-reviews, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[marge-m59] Add "mark promise as handled" change to pipeThrough() Update the implementation of ReadableStream pipeThrough() with standard change https://github.com/whatwg/streams/commit/94140088224c1a0e219c630378d1fa7985d657a9 This makes it mark the Promise returned by pipeTo() as handled to avoid uncatchable rejections when pipeTo fails. TBR=tyoshino BUG=714076 Review-Url: https://codereview.chromium.org/2796633002 Cr-Commit-Position: refs/heads/master@{#464718} (cherry picked from commit 1e9fa3b2e7dca2ba228b9720570512676ed23798) Review-Url: https://codereview.chromium.org/2837753002 . Cr-Commit-Position: refs/branch-heads/3071@{#153} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/d1f38b5f8bbfe40aacfafabe89dc1de7f465db9d

Patch Set 1 #

Messages

Total messages: 3 (1 generated)
Adam Rice
Committed patchset #1 (id:1) manually as d1f38b5f8bbfe40aacfafabe89dc1de7f465db9d (presubmit successful).
3 years, 8 months ago (2017-04-24 02:08:17 UTC) #2
tyoshino (SeeGerritForStatus)
3 years, 8 months ago (2017-04-24 04:05:29 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698