Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2837613002: cros: Fix race on feedback extension loading (Closed)

Created:
3 years, 8 months ago by xiyuan
Modified:
3 years, 8 months ago
Reviewers:
Qiang(Joe) Xu
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Fix race on feedback extension loading - Move ExtensionHost check before loading feedback extension to fix the race that ExtensionHost check could run after the loading makes feedback background page up and running; - Handle the case where feedkback background host already exists, just in case. - Add a retry in EnsureFeedbackUI to be sure the UI will be created; BUG=711123 Review-Url: https://codereview.chromium.org/2837613002 Cr-Commit-Position: refs/heads/master@{#466395} Committed: https://chromium.googlesource.com/chromium/src/+/24d15b15c85b8d3a60c6985add50824fa6602467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -13 lines) Patch
M chrome/browser/chromeos/login/ui/login_feedback.cc View 7 chunks +33 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
xiyuan
3 years, 8 months ago (2017-04-21 16:19:47 UTC) #2
Qiang(Joe) Xu
On 2017/04/21 16:19:47, xiyuan wrote: LGTM
3 years, 8 months ago (2017-04-21 17:47:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837613002/1
3 years, 8 months ago (2017-04-21 18:08:29 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 18:13:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/24d15b15c85b8d3a60c6985add50...

Powered by Google App Engine
This is Rietveld 408576698