Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1322)

Unified Diff: third_party/WebKit/Source/web/WebFrameImplBase.h

Issue 2837593002: Nuked WebFrameImplBase. (Closed)
Patch Set: Replaced non-null params with refs. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebFrame.cpp ('k') | third_party/WebKit/Source/web/WebFrameImplBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebFrameImplBase.h
diff --git a/third_party/WebKit/Source/web/WebFrameImplBase.h b/third_party/WebKit/Source/web/WebFrameImplBase.h
deleted file mode 100644
index 409179099e8db6dc111fd0ddd79fabb10473d689..0000000000000000000000000000000000000000
--- a/third_party/WebKit/Source/web/WebFrameImplBase.h
+++ /dev/null
@@ -1,48 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef WebFrameImplBase_h
-#define WebFrameImplBase_h
-
-#include "platform/heap/Handle.h"
-#include "platform/wtf/text/AtomicString.h"
-#include "web/WebExport.h"
-
-namespace blink {
-
-class Frame;
-class FrameOwner;
-class Page;
-
-// WebFrameImplBase exists to avoid the diamond inheritance problem:
-// - The public interfaces WebLocalFrame/WebRemoteFrame extend WebFrame.
-// - WebLocalFrameImpl implements WebLocalFrame and WebRemoteFrameImpl
-// implements WebRemoteFrame.
-// - The private implementations should share some functionality, but cannot
-// inherit from a common base class inheriting WebFrame. This would result in
-// WebFrame beind inherited from two different base classes.
-//
-// To get around this, only the private implementations have WebFrameImplBase as
-// a base class. WebFrame exposes a virtual accessor to retrieve the underlying
-// implementation as an instance of the base class, but has no inheritance
-// relationship with it. The cost is a virtual indirection, but this is nicer
-// than the previous manual dispatch emulating real virtual dispatch.
-class WEB_EXPORT WebFrameImplBase
- : public GarbageCollectedFinalized<WebFrameImplBase> {
- public:
- virtual ~WebFrameImplBase();
-
- virtual void InitializeCoreFrame(Page&,
- FrameOwner*,
- const AtomicString& name) = 0;
- // TODO(dcheng): Rename this to coreFrame()? This probably also shouldn't be
- // const...
- virtual Frame* GetFrame() const = 0;
-
- DECLARE_VIRTUAL_TRACE();
-};
-
-} // namespace blink
-
-#endif // WebFrameImplBase_h
« no previous file with comments | « third_party/WebKit/Source/web/WebFrame.cpp ('k') | third_party/WebKit/Source/web/WebFrameImplBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698