Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Side by Side Diff: third_party/WebKit/Source/web/WebFrameImplBase.h

Issue 2837593002: Nuked WebFrameImplBase. (Closed)
Patch Set: Replaced non-null params with refs. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef WebFrameImplBase_h
6 #define WebFrameImplBase_h
7
8 #include "platform/heap/Handle.h"
9 #include "platform/wtf/text/AtomicString.h"
10 #include "web/WebExport.h"
11
12 namespace blink {
13
14 class Frame;
15 class FrameOwner;
16 class Page;
17
18 // WebFrameImplBase exists to avoid the diamond inheritance problem:
19 // - The public interfaces WebLocalFrame/WebRemoteFrame extend WebFrame.
20 // - WebLocalFrameImpl implements WebLocalFrame and WebRemoteFrameImpl
21 // implements WebRemoteFrame.
22 // - The private implementations should share some functionality, but cannot
23 // inherit from a common base class inheriting WebFrame. This would result in
24 // WebFrame beind inherited from two different base classes.
25 //
26 // To get around this, only the private implementations have WebFrameImplBase as
27 // a base class. WebFrame exposes a virtual accessor to retrieve the underlying
28 // implementation as an instance of the base class, but has no inheritance
29 // relationship with it. The cost is a virtual indirection, but this is nicer
30 // than the previous manual dispatch emulating real virtual dispatch.
31 class WEB_EXPORT WebFrameImplBase
32 : public GarbageCollectedFinalized<WebFrameImplBase> {
33 public:
34 virtual ~WebFrameImplBase();
35
36 virtual void InitializeCoreFrame(Page&,
37 FrameOwner*,
38 const AtomicString& name) = 0;
39 // TODO(dcheng): Rename this to coreFrame()? This probably also shouldn't be
40 // const...
41 virtual Frame* GetFrame() const = 0;
42
43 DECLARE_VIRTUAL_TRACE();
44 };
45
46 } // namespace blink
47
48 #endif // WebFrameImplBase_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebFrame.cpp ('k') | third_party/WebKit/Source/web/WebFrameImplBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698