Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2837573002: Revert of PlzNavigate: add dump to understand pdf navigation cancellation (Closed)

Created:
3 years, 8 months ago by clamy
Modified:
3 years, 8 months ago
Reviewers:
nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of PlzNavigate: add dump to understand pdf navigation cancellation (patchset #2 id:20001 of https://codereview.chromium.org/2823613002/ ) Reason for revert: Reverting since we got the data needed. Original issue's description: > PlzNavigate: add dump to understand pdf navigation cancellation > > This CL adds a DumpWithoutCrashing to try to understand why navigations > to pdf are cancelled when PlzNavigate is enabled. > > BUG=709771 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2823613002 > Cr-Commit-Position: refs/heads/master@{#465418} > Committed: https://chromium.googlesource.com/chromium/src/+/70fd878b6b7abc27c01a68f35b82bee5f51ba03e TBR=nasko@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=709771 Review-Url: https://codereview.chromium.org/2837573002 Cr-Commit-Position: refs/heads/master@{#466320} Committed: https://chromium.googlesource.com/chromium/src/+/a7629595cadb7b48331e9ae449d715693ac8e385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M content/browser/frame_host/navigation_request.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
clamy
Created Revert of PlzNavigate: add dump to understand pdf navigation cancellation
3 years, 8 months ago (2017-04-21 12:13:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837573002/1
3 years, 8 months ago (2017-04-21 12:13:33 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 13:06:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a7629595cadb7b48331e9ae449d7...

Powered by Google App Engine
This is Rietveld 408576698