Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2837503002: Move (Resize|Rotation)ViewportAnchor.* from web/ to core/frame/. (Closed)

Created:
3 years, 8 months ago by slangley
Modified:
3 years, 8 months ago
Reviewers:
tkent, haraken, joelhockey
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move (Resize|Rotation)ViewportAnchor.* from web/ to core/frame/. Neither of these classes are implementation of a public/web/ API, and seem to deal with frame concepts, so moved them to core/frame/. BUG=712963 Review-Url: https://codereview.chromium.org/2837503002 Cr-Commit-Position: refs/heads/master@{#466251} Committed: https://chromium.googlesource.com/chromium/src/+/06ef861b588ced08e4f3d7cf156fe3883e20715f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -461 lines) Patch
M third_party/WebKit/Source/core/frame/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/frame/ResizeViewportAnchor.h View 2 chunks +2 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/core/frame/ResizeViewportAnchor.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/frame/RotationViewportAnchor.h View 2 chunks +2 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/core/frame/RotationViewportAnchor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/web/ResizeViewportAnchor.h View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/Source/web/ResizeViewportAnchor.cpp View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/Source/web/RotationViewportAnchor.h View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/WebKit/Source/web/RotationViewportAnchor.cpp View 1 chunk +0 lines, -254 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
slangley
3 years, 8 months ago (2017-04-21 00:54:05 UTC) #2
joelhockey
lgtm
3 years, 8 months ago (2017-04-21 00:58:40 UTC) #3
slangley
tkent@ - ptal
3 years, 8 months ago (2017-04-21 01:31:08 UTC) #5
tkent
lgtm
3 years, 8 months ago (2017-04-21 01:56:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837503002/1
3 years, 8 months ago (2017-04-21 01:59:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/06ef861b588ced08e4f3d7cf156fe3883e20715f
3 years, 8 months ago (2017-04-21 03:53:59 UTC) #11
haraken
3 years, 8 months ago (2017-04-21 06:44:29 UTC) #12
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698