Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2837463002: DevTools: allow capturing screenshots from command menu. (Closed)

Created:
3 years, 8 months ago by pfeldman
Modified:
3 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: allow capturing screenshots from command menu. BUG=713925 Review-Url: https://codereview.chromium.org/2837463002 Cr-Commit-Position: refs/heads/master@{#466476} Committed: https://chromium.googlesource.com/chromium/src/+/b60e2ced1a030d08ccb1dbcfd60ed62e3b6f9d13

Patch Set 1 #

Patch Set 2 : clean #

Total comments: 4

Patch Set 3 : clean #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -15 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 1 2 2 chunks +13 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeWrapper.js View 1 2 2 chunks +9 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
pfeldman
3 years, 8 months ago (2017-04-20 23:49:38 UTC) #2
pfeldman
:/
3 years, 8 months ago (2017-04-21 01:18:05 UTC) #3
dgozman
lgtm https://codereview.chromium.org/2837463002/diff/20001/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js File third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js (right): https://codereview.chromium.org/2837463002/diff/20001/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js#newcode663 third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js:663: this._calculateAndEmulate(false); You can move this back now. https://codereview.chromium.org/2837463002/diff/20001/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeWrapper.js ...
3 years, 8 months ago (2017-04-21 20:40:54 UTC) #4
pfeldman
https://codereview.chromium.org/2837463002/diff/20001/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js File third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js (right): https://codereview.chromium.org/2837463002/diff/20001/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js#newcode663 third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js:663: this._calculateAndEmulate(false); On 2017/04/21 20:40:54, dgozman wrote: > You can ...
3 years, 8 months ago (2017-04-21 20:51:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837463002/40001
3 years, 8 months ago (2017-04-21 20:58:39 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 22:40:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b60e2ced1a030d08ccb1dbcfd60e...

Powered by Google App Engine
This is Rietveld 408576698