Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Issue 2837383002: Raise an error when calling WebCrypto's deriveBits() for HKDF with (Closed)

Created:
3 years, 8 months ago by eroman
Modified:
3 years, 8 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Raise an error when calling WebCrypto's deriveBits() for HKDF with non-multiple of 8 length. BUG=714847 Review-Url: https://codereview.chromium.org/2837383002 Cr-Commit-Position: refs/heads/master@{#467411} Committed: https://chromium.googlesource.com/chromium/src/+/4451821b58a52fce62d9a5d197eef2e8d7dac949

Patch Set 1 #

Patch Set 2 : checkpoint #

Patch Set 3 : moar #

Patch Set 4 : checkpoint #

Patch Set 5 : checkpoint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -11 lines) Patch
M components/webcrypto/algorithms/hkdf.cc View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M components/webcrypto/status.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M components/webcrypto/status.cc View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/hkdf/deriveBits.html View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/hkdf/deriveBits-expected.txt View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/hkdf/deriveBits-failures.html View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/hkdf/deriveBits-failures-expected.txt View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (18 generated)
eroman
Oddly I don't get any failures when running the blink trybots (but should as there ...
3 years, 8 months ago (2017-04-26 19:11:13 UTC) #16
Ryan Sleevi
lgtm
3 years, 8 months ago (2017-04-26 19:13:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837383002/80001
3 years, 8 months ago (2017-04-26 19:20:25 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 19:30:38 UTC) #22
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/4451821b58a52fce62d9a5d197ee...

Powered by Google App Engine
This is Rietveld 408576698