Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(76)

Issue 2837353003: Remove remaining traces of ServiceWorkerMessageEvent (Closed)

Created:
2 years, 3 months ago by foolip
Modified:
2 years, 3 months ago
Reviewers:
haraken, jbroman, bashi
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, falken+watch_chromium.org, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, shimazu+serviceworker_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove remaining traces of ServiceWorkerMessageEvent The ServiceWorkerMessageEvent.* files were already removed from BUILD.gn: https://codereview.chromium.org/2466513002 This inlines the templatized helpers in V8ServiceWorkerMessageEventInternal.h into non-templated code in V8ExtendableMessageEventCustom.cpp, which is now the only place the helpers are used. BUG=659074 Review-Url: https://codereview.chromium.org/2837353003 Cr-Commit-Position: refs/heads/master@{#467291} Committed: https://chromium.googlesource.com/chromium/src/+/2369b7f3dec2f78a760ed52bf64badb2240a1968

Patch Set 1 #

Patch Set 2 : include V8PrivateProperty.h #

Messages

Total messages: 18 (11 generated)
foolip
PTAL :)
2 years, 3 months ago (2017-04-26 08:42:44 UTC) #5
foolip
Adding bashi@ as well, as he appears in a TODO.
2 years, 3 months ago (2017-04-26 08:43:27 UTC) #7
haraken
LGTM
2 years, 3 months ago (2017-04-26 09:05:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837353003/20001
2 years, 3 months ago (2017-04-26 10:30:31 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/2369b7f3dec2f78a760ed52bf64badb2240a1968
2 years, 3 months ago (2017-04-26 10:34:19 UTC) #15
jbroman
Well, belated lgtm too. :)
2 years, 3 months ago (2017-04-26 14:48:00 UTC) #17
bashi
2 years, 3 months ago (2017-04-26 23:02:05 UTC) #18
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698