Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2837353002: mojo: Make EqualsTraits<> part of public C++ API (Closed)

Created:
3 years, 8 months ago by James Cook
Modified:
3 years, 8 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo: Make EqualsTraits<> part of public C++ API Users of mapped types sometimes need to provide their own custom comparsion functions for classes that do not provide operator==() or an Equals() method. Move EqualsTraits<> out of mojo internals, similar to how CloneTraits<> is handled. BUG=714689 TEST=compiles Review-Url: https://codereview.chromium.org/2837353002 Cr-Commit-Position: refs/heads/master@{#467160} Committed: https://chromium.googlesource.com/chromium/src/+/b9404e80f80b4bddfa2c24ca042393ceb5a5b882

Patch Set 1 #

Patch Set 2 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -114 lines) Patch
M mojo/public/cpp/bindings/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
A + mojo/public/cpp/bindings/equals_traits.h View 1 7 chunks +13 lines, -9 lines 0 comments Download
D mojo/public/cpp/bindings/lib/equals_traits.h View 1 chunk +0 lines, -94 lines 0 comments Download
M mojo/public/cpp/bindings/lib/wtf_clone_equals_util.h View 3 chunks +3 lines, -6 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_template_definition.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_template_definition.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
James Cook
yzshen, please take a look.
3 years, 8 months ago (2017-04-25 18:16:08 UTC) #3
yzshen1
lgtm
3 years, 8 months ago (2017-04-25 18:22:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837353002/20001
3 years, 8 months ago (2017-04-25 21:57:56 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 23:24:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b9404e80f80b4bddfa2c24ca0423...

Powered by Google App Engine
This is Rietveld 408576698