Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/trace_helper.h

Issue 2837323002: Merged all PointerToId functions into TraceHelper::PointerToString. (Closed)
Patch Set: Rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/base/trace_helper.h
diff --git a/third_party/WebKit/Source/platform/scheduler/base/trace_helper.h b/third_party/WebKit/Source/platform/scheduler/base/trace_helper.h
new file mode 100644
index 0000000000000000000000000000000000000000..372561988b9a579b7c64a68f0dbc08b031016dc8
--- /dev/null
+++ b/third_party/WebKit/Source/platform/scheduler/base/trace_helper.h
@@ -0,0 +1,22 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_BASE_TRACE_HELPER_H
+#define THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_BASE_TRACE_HELPER_H
+
+#include <string>
+
+namespace blink {
+namespace scheduler {
+
+class TraceHelper {
jochen (gone - plz use gerrit) 2017/05/11 08:53:11 nit. should be a namespace (all static classes in
Daniel Bratell 2017/05/11 11:51:20 Done.
+ public:
+ static std::string PointerToString(const void* pointer,
+ bool add_hex_prefix = true);
jochen (gone - plz use gerrit) 2017/05/11 08:53:11 ideally that would be an enum class, no a bool
Daniel Bratell 2017/05/11 11:51:20 I have been uncertain about this flag since it's o
+};
+
+} // namespace scheduler
+} // namespace blink
+
+#endif // THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_BASE_TRACE_HELPER_H

Powered by Google App Engine
This is Rietveld 408576698