Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2837303002: diagnose_apk_bloat.py: add diff summary. (Closed)

Created:
3 years, 8 months ago by estevenson
Modified:
3 years, 8 months ago
Reviewers:
agrieve
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

diagnose_apk_bloat.py: add diff summary. This CL changes diagnose_apk_bloat.py to write a summary for newly generated diffs (normalized APK size delta for Android and native lib delta for Linux). BUG=710076 Review-Url: https://codereview.chromium.org/2837303002 Cr-Commit-Position: refs/heads/master@{#467083} Committed: https://chromium.googlesource.com/chromium/src/+/20184aeaa410802d38d8cad0d491ed9bed09d512

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -15 lines) Patch
M tools/binary_size/diagnose_apk_bloat.py View 12 chunks +63 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
estevenson
3 years, 8 months ago (2017-04-25 19:44:48 UTC) #3
agrieve
lgtm
3 years, 8 months ago (2017-04-25 19:46:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837303002/1
3 years, 8 months ago (2017-04-25 19:51:49 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 20:06:00 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/20184aeaa410802d38d8cad0d491...

Powered by Google App Engine
This is Rietveld 408576698