Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2837293002:
[InputEvent] Mark InputEvent and StaticRange as stable (Closed)
Description[InputEvent] Mark InputEvent and StaticRange as stable
Currently |StaticRange| is only used in |InputEvent|. Discussions about both IDLs are
covered in the intent below.
Intent to ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/W-Q1yWW-zas/ezkF3lw9CAAJ
BUG=585875
Review-Url: https://codereview.chromium.org/2837293002
Cr-Commit-Position: refs/heads/master@{#467597}
Committed: https://chromium.googlesource.com/chromium/src/+/5fdb3237636167dfb535cd5ef8a535e5b9f8b662
Patch Set 1 #
Messages
Total messages: 32 (22 generated)
The CQ bit was checked by chongz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Mark InputEvent and StaticRange as stable BUG=585875 ========== to ========== [InputEvent] Mark InputEvent and StaticRange as stable Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/W-Q1yWW-zas/ezkF3lw9... BUG=585875 ==========
Description was changed from ========== [InputEvent] Mark InputEvent and StaticRange as stable Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/W-Q1yWW-zas/ezkF3lw9... BUG=585875 ========== to ========== [InputEvent] Mark InputEvent and StaticRange as stable Currently |StaticRange| is only used in |InputEvent|. Discussions to ship both IDLs are covered in the intent below. Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/W-Q1yWW-zas/ezkF3lw9... BUG=585875 ==========
Description was changed from ========== [InputEvent] Mark InputEvent and StaticRange as stable Currently |StaticRange| is only used in |InputEvent|. Discussions to ship both IDLs are covered in the intent below. Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/W-Q1yWW-zas/ezkF3lw9... BUG=585875 ========== to ========== [InputEvent] Mark InputEvent and StaticRange as stable Currently |StaticRange| is only used in |InputEvent|. Discussions about both IDLs are covered in the intent below. Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/W-Q1yWW-zas/ezkF3lw9... BUG=585875 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by chongz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
chongz@chromium.org changed reviewers: + foolip@chromium.org
foolip@ PTAL, thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by foolip@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
chongz@chromium.org changed reviewers: + aelias@chromium.org
aelias@ PTAL at Android change, thanks!
lgtm
The CQ bit was checked by chongz@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by chongz@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493272146844790,
"parent_rev": "47564c7bf17d2fd560b4390ba714d19d4d9e2550", "commit_rev":
"5fdb3237636167dfb535cd5ef8a535e5b9f8b662"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493272146844790,
"parent_rev": "47564c7bf17d2fd560b4390ba714d19d4d9e2550", "commit_rev":
"5fdb3237636167dfb535cd5ef8a535e5b9f8b662"}
Message was sent while issue was closed.
Description was changed from ========== [InputEvent] Mark InputEvent and StaticRange as stable Currently |StaticRange| is only used in |InputEvent|. Discussions about both IDLs are covered in the intent below. Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/W-Q1yWW-zas/ezkF3lw9... BUG=585875 ========== to ========== [InputEvent] Mark InputEvent and StaticRange as stable Currently |StaticRange| is only used in |InputEvent|. Discussions about both IDLs are covered in the intent below. Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/W-Q1yWW-zas/ezkF3lw9... BUG=585875 Review-Url: https://codereview.chromium.org/2837293002 Cr-Commit-Position: refs/heads/master@{#467597} Committed: https://chromium.googlesource.com/chromium/src/+/5fdb3237636167dfb535cd5ef8a5... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/5fdb3237636167dfb535cd5ef8a5... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
